Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 099B913364DE for ; Sun, 27 Feb 2011 13:42:09 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 04839-02 for ; Sun, 27 Feb 2011 17:42:01 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from momjian.us (momjian.us [70.90.9.53]) by mail.postgresql.org (Postfix) with ESMTP id 5BE621337B4E for ; Sun, 27 Feb 2011 13:42:01 -0400 (AST) Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id p1RHfxw06463; Sun, 27 Feb 2011 12:41:59 -0500 (EST) From: Bruce Momjian Message-Id: <201102271741.p1RHfxw06463@momjian.us> Subject: Re: Documenting removal of nonnullvalue() and friends In-Reply-To: <10715.1298828414@sss.pgh.pa.us> To: Tom Lane Date: Sun, 27 Feb 2011 12:41:59 -0500 (EST) CC: Peter Eisentraut , Robert Haas , Josh Kupershmidt , pgsql-docs@postgresql.org X-Mailer: ELM [version 2.4ME+ PL124 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201102/82 X-Sequence-Number: 6430 Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> I thought about this a bit more last night. It's certainly true that > >> a lot of "internal" functions have comments that don't suggest that > >> they're not meant to be used directly. What I think would be a good > >> plan for functions that underlie operators is that we move any useful > >> comments from pg_proc to pg_operator, and then install a comment in > >> pg_proc that says "implementation of operator +" (or whatever the > >> operator name is). > >> ... > >> If that sounds like a reasonable plan, I'm willing to have a go at it > >> after the commitfest closes. > > > Tom, any work on this? A TODO? > > I haven't done anything about this yet, but it's still on my to-do list. > Right now (or at least after I finish the patches I'm working on) would > probably be about the best possible time to do it, since hopefully we > have the minimum number of unapplied patches that would need to be > revised to follow the new convention. Good point. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +