Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 374E4B5DC10 for ; Tue, 6 Sep 2011 01:22:27 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 01711-04 for ; Tue, 6 Sep 2011 04:22:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from fetter.org (173-164-140-181-SFBA.hfc.comcastbusiness.net [173.164.140.181]) by mail.postgresql.org (Postfix) with ESMTP id B4F5FB5DBD1 for ; Tue, 6 Sep 2011 01:22:19 -0300 (ADT) Received: by fetter.org (Postfix, from userid 500) id 290C23C2C12; Mon, 5 Sep 2011 21:22:18 -0700 (PDT) Date: Mon, 5 Sep 2011 21:22:18 -0700 From: David Fetter To: Alvaro Herrera Cc: Bruce Momjian , Kevin Grittner , Thom Brown , PostgreSQL-development Subject: Re: Couple document fixes Message-ID: <20110906042218.GM3924@fetter.org> References: <20110905232916.GK3924@fetter.org> <201109052333.p85NX9F26135@momjian.us> <20110906000509.GL3924@fetter.org> <1315271205-sup-7449@alvh.no-ip.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1315271205-sup-7449@alvh.no-ip.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-0.918 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RDNS_DYNAMIC=0.982 X-Spam-Level: X-Archive-Number: 201109/237 X-Sequence-Number: 194426 On Mon, Sep 05, 2011 at 10:07:29PM -0300, Alvaro Herrera wrote: > Excerpts from David Fetter's message of lun sep 05 21:05:10 -0300 2011: > > > On brief inspection, it appears that each of these would be better > > served, at least functionally, with some kind of enumerated type. > > Might it be worth trying to micro-optimize this case for a one-byte > > enum? Or maybe something like the varvarlena pattern? > > What would be the point? Removing the legacy "char" type, per original post. :) > It works pretty well already. It doesn't need fixing. We've made changes as big on aesthetic grounds before, and if the change results in an enum type optimized for space efficiency, that's all to the good. Cheers, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate