From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201109070254.p872sd418092@momjian.us>
Subject: Re: [BUGS] documentation bug - behave of NEW a OLD in
	plpgsql's triggers
In-Reply-To: <BANLkTikzDpBjvUmkoYFWQVPDOdmYX=KFKw@mail.gmail.com>
To: Josh Kupershmidt <schmiddy@gmail.com>
Date: Tue, 6 Sep 2011 22:54:39 -0400 (EDT)
CC: Pavel Stehule <pavel.stehule@gmail.com>,
	pgsql-docs <pgsql-docs@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Josh Kupershmidt wrote:
> [Moving to -docs]
> 
> On Mon, May 2, 2011 at 12:00 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> > Hello
> >
> > one czech user reported a bug in documentation -
> > http://www.postgresql.org/docs/8.4/static/plpgsql-trigger.html
> >
> > NEW
> >
> > ? ?Data type RECORD; variable holding the new database row for
> > INSERT/UPDATE operations in row-level triggers. This variable is NULL
> > in statement-level triggers and for DELETE operations.
> > OLD
> >
> > ? ?Data type RECORD; variable holding the old database row for
> > UPDATE/DELETE operations in row-level triggers. This variable is NULL
> > in statement-level triggers and for INSERT operations.
> >
> > It isn't correct. NEW is not declared in DELETE trigger, OLD isn't
> > declared in INSERT
> 
> If I've understood you correctly, the problem is that the docs claim
> that the variables are defined with a value of NULL, when in fact they
> are undefined. For example, if you try to use variable NEW in a delete
> trigger, you'll get an error message like:
> |  ERROR:  record "new" is not assigned yet
> |  DETAIL:  The tuple structure of a not-yet-assigned record is indeterminate.
> 
> How about a doc tweak like the attached?

Perfect.  Applied to 9.0, 9.1, and head.  Thanks.  Sorry for the delay.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +