public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Susanne Ebrecht <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Grzegorz Szpetkowski <[email protected]>
Cc: [email protected]
Subject: Re: createuser/dropuser username
Date: Thu, 8 Sep 2011 09:14:26 -0400 (EDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Tom Lane wrote:
> Bruce Momjian <[email protected]> writes:
> > Uh, I did some digging after this email report and found it does need
> > some cleanup, which is done in the attached patch.
> 
> > It removes quoting for table references in clusterdb and index/table
> > references in reindexdb,
> 
> Uh, surely that breaks things.  Or did you miss my statement that the
> current behavior is what is intended?
> 
> > and adds a general documentation overview about
> > when case is preserved and suggests quoting, and adds documentation
> > where special quoting happens.
> 
> I don't find the documentation changes to be improvements either.
> Possibly instead of
> 
> > !         Specifies the default tablespace for the database (double-quoted internally).
> 
> you could do something like
> 
>          Specifies the default tablespace for the database.  (This name
>          is not subject to case-folding.)

Actually, that is inaccurate.  When we call PQconnectdbParams() with
username/database names, or call fmtId(), we are doing more than
preserving case.  We are also preserving whitespace and special
characters.  I can make the new text:

	(This name is processed as a double-quoted identifier.)

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: createuser/dropuser username
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox