Received: from maia.hub.org (maia-3.hub.org [200.46.204.243])
	by mail.postgresql.org (Postfix) with ESMTP id 214A7B5DC01
	for <pgsql-docs-postgresql.org@mail.postgresql.org>;
	Sat, 10 Sep 2011 11:47:24 -0300 (ADT)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia,
	port 10024) with ESMTP id 47077-06 for
	<pgsql-docs-postgresql.org@mail.postgresql.org>;
	Sat, 10 Sep 2011 14:47:17 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from momjian.us (momjian.us [70.90.9.53])
	by mail.postgresql.org (Postfix) with ESMTP id 186FEB5DBFC
	for <pgsql-docs@postgresql.org>; Sat, 10 Sep 2011 11:47:16 -0300 (ADT)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 p8AElF813203;
	Sat, 10 Sep 2011 10:47:15 -0400 (EDT)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201109101447.p8AElF813203@momjian.us>
Subject: Re: 7.1. Overview (The SQL Language)
In-Reply-To: 
To: Grzegorz Szpetkowski <gszpetkowski@gmail.com>
Date: Sat, 10 Sep 2011 10:47:15 -0400 (EDT)
CC: pgsql-docs@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL124 (25)]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1315666035-11212-0_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.404 tagged_above=-5 required=5 tests=BAYES_00=-1.9,
	RP_MATCHES_RCVD=-0.504
X-Spam-Level: 
X-Archive-Number: 201109/39
X-Sequence-Number: 6960


--ELM1315666035-11212-0_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

bruce wrote:
> Grzegorz Szpetkowski wrote:
> > http://www.postgresql.org/docs/9.0/static/queries-overview.html
> > 
> > "Assuming that there is a table called table1, this command would
> > retrieve all rows and all columns from table1."
> > 
> > Maybe it's worth adding:
> > 
> > "Assuming that there is a table called table1, this command would
> > retrieve all rows and all columns (excluding system columns described
> > at Section 5.4) from table1."
> 
> I considered this but it seems like too much detail for the overview
> section.

On second thought, I added the "user-defined" modifier to the sentence; 
applid patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--ELM1315666035-11212-0_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Content-Disposition: inline; filename="/rtmp/user-defined"

commit 90108c9aab51840a0fa7bcb11a2da09204d5b003
Author: Bruce Momjian <bruce@momjian.us>
Date:   Sat Sep 10 10:45:55 2011 -0400

    Document that only user-defined columns are expanded by SELECT *.

diff --git a/doc/src/sgml/queries.sgml b/doc/src/sgml/queries.sgml
new file mode 100644
index 7ca640e..a3dadbe
*** a/doc/src/sgml/queries.sgml
--- b/doc/src/sgml/queries.sgml
***************
*** 41,47 ****
  SELECT * FROM table1;
  </programlisting>
    Assuming that there is a table called <literal>table1</literal>,
!   this command would retrieve all rows and all columns from
    <literal>table1</literal>.  (The method of retrieval depends on the
    client application.  For example, the
    <application>psql</application> program will display an ASCII-art
--- 41,47 ----
  SELECT * FROM table1;
  </programlisting>
    Assuming that there is a table called <literal>table1</literal>,
!   this command would retrieve all rows and all user-defined columns from
    <literal>table1</literal>.  (The method of retrieval depends on the
    client application.  For example, the
    <application>psql</application> program will display an ASCII-art

--ELM1315666035-11212-0_--