Received: from makus.postgresql.org ([98.129.198.125])
	by malur.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T1fot-00043X-Qh
	for pgsql-docs@postgresql.org; Wed, 15 Aug 2012 15:47:43 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T1fos-0006CE-Dh
	for pgsql-docs@postgresql.org; Wed, 15 Aug 2012 15:47:43 +0000
Received: from bruce by momjian.us with local (Exim 4.72)
	(envelope-from <bruce@momjian.us>)
	id 1T1for-0001V8-1M; Wed, 15 Aug 2012 11:47:41 -0400
Date: Wed, 15 Aug 2012 11:47:41 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Thom Brown <thom@linux.com>, pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: Foreign server version and type
Message-ID: <20120815154741.GH25473@momjian.us>
References: 
 <CAA-aLv4xVYzcsE9k2mAT8BoBnJ+XeR8s4xDpH6CojQ3iiS5wPQ@mail.gmail.com>
	<4E495924.3010405@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="w7PDEPdKQumQfZlR"
Content-Disposition: inline
In-Reply-To: <4E495924.3010405@enterprisedb.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201208/22
X-Sequence-Number: 7415


--w7PDEPdKQumQfZlR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 15, 2011 at 08:36:36PM +0300, Heikki Linnakangas wrote:
> On 15.08.2011 19:58, Thom Brown wrote:
> >I'm looking at the CREATE SERVER page on the documentation (
> >http://www.postgresql.org/docs/9.1/static/sql-createserver.html) and noticed
> >that there's a server_version parameter which can be provided with the
> >keyword VERSION and server_type specified after TYPE.
> >
> >However, there's zero information about what these are used for, whether
> >they have any bearing on anything or why you'd want to use them.  Are these
> >parameters used for anything, or are they purely for future functionality?
> >  Whatever the case, could some kind of elaboration be added to justify the
> >existence of these options?  They have been in the docs since the CREATE
> >SERVER syntax was introduced in 8.4.
> 
> It's in the SQL spec. It isn't used anything by PostgreSQL itself,
> but a wrapper could look at it. It would probably be good to say
> that explicitly in the docs.

I have applied the attached patch to document that these fields are only
potentially useful to foreign data wrappers.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--w7PDEPdKQumQfZlR
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="foreign.diff"

diff --git a/doc/src/sgml/ref/create_server.sgml b/doc/src/sgml/ref/create_server.sgml
new file mode 100644
index be9be50..60744b2
*** a/doc/src/sgml/ref/create_server.sgml
--- b/doc/src/sgml/ref/create_server.sgml
*************** CREATE SERVER <replaceable class="parame
*** 69,75 ****
      <term><replaceable class="parameter">server_type</replaceable></term>
      <listitem>
       <para>
!       Optional server type.
       </para>
      </listitem>
     </varlistentry>
--- 69,75 ----
      <term><replaceable class="parameter">server_type</replaceable></term>
      <listitem>
       <para>
!       Optional server type, potentially useful to foreign-data wrappers.
       </para>
      </listitem>
     </varlistentry>
*************** CREATE SERVER <replaceable class="parame
*** 78,84 ****
      <term><replaceable class="parameter">server_version</replaceable></term>
      <listitem>
       <para>
!       Optional server version.
       </para>
      </listitem>
     </varlistentry>
--- 78,84 ----
      <term><replaceable class="parameter">server_version</replaceable></term>
      <listitem>
       <para>
!       Optional server version, potentially useful to foreign-data wrappers.
       </para>
      </listitem>
     </varlistentry>

--w7PDEPdKQumQfZlR--