Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T1o6j-0001jE-Pr
	for pgsql-docs@postgresql.org; Thu, 16 Aug 2012 00:38:41 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T1o6g-0005EM-Eo
	for pgsql-docs@postgresql.org; Thu, 16 Aug 2012 00:38:41 +0000
Received: from bruce by momjian.us with local (Exim 4.72)
	(envelope-from <bruce@momjian.us>)
	id 1T1o6e-0003XK-Mn; Wed, 15 Aug 2012 20:38:36 -0400
Date: Wed, 15 Aug 2012 20:38:36 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Ray Stell <stellr@cns.vt.edu>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-docs@postgresql.org
Subject: Re: create foreign table
Message-ID: <20120816003836.GB8353@momjian.us>
References: <20110915165157.GA24580@cns.vt.edu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="+g7M9IMkV8truYOl"
Content-Disposition: inline
In-Reply-To: <20110915165157.GA24580@cns.vt.edu>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201208/25
X-Sequence-Number: 7418


--+g7M9IMkV8truYOl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 15, 2011 at 12:51:57PM -0400, Ray Stell wrote:
> On Thu, Sep 15, 2011 at 06:43:59AM -0500, Robert Haas wrote:
> >> On Mon, Sep 12, 2011 at 8:42 AM, Ray Stell <stellr@cns.vt.edu> wrote:
> >> > http://www.postgresql.org/docs/9.1/static/sql-createforeigntable.html
> >> > It would be helpful if "SERVER" was defined if the parameters list
> >> > on this page.
> >>
> >> We don't usually document required keywords - they're just required.
> >> We do document the meaning of server_name, which I think is probably
> >> what you were after.
> >>
> >> --
> >> Robert Haas
> >> EnterpriseDB: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
> >Thanks, Robert.
> >
> >Maybe if you just added a pointer to the "CREATE SERVER" command in
> >your definition of server_name it would provide a bread crumb.
> >
> 
> Oh, I see my mistake.  Maybe the inclusion of a link to "CREATE SERVER"
> http://www.postgresql.org/docs/9.1/static/sql-createserver.html in the
> server_name definition would be helpful, just like in the data_type line.
> I was having trouble making the leap since the idea was a new one on me.

I have done as you suggested with the attached patch which will appear
in Postgres 9.3.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--+g7M9IMkV8truYOl
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="server.diff"

diff --git a/doc/src/sgml/ref/create_foreign_table.sgml b/doc/src/sgml/ref/create_foreign_table.sgml
new file mode 100644
index 2113d00..f860ad0
*** a/doc/src/sgml/ref/create_foreign_table.sgml
--- b/doc/src/sgml/ref/create_foreign_table.sgml
*************** CREATE FOREIGN TABLE [ IF NOT EXISTS ] <
*** 135,141 ****
      <listitem>
       <para>
        The name of an existing server for the foreign table.
!      </para>
      </listitem>
     </varlistentry>
  
--- 135,142 ----
      <listitem>
       <para>
        The name of an existing server for the foreign table.
!       For details on defining a server, see <xref
!       linkend="SQL-CREATESERVER">.
      </listitem>
     </varlistentry>
  

--+g7M9IMkV8truYOl--