Received: from makus.postgresql.org ([98.129.198.125])
	by malur.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T2ByM-0001fv-LL
	for pgsql-docs@postgresql.org; Fri, 17 Aug 2012 02:07:38 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T2ByK-0001Va-Pp
	for pgsql-docs@postgresql.org; Fri, 17 Aug 2012 02:07:37 +0000
Received: from bruce by momjian.us with local (Exim 4.72)
	(envelope-from <bruce@momjian.us>)
	id 1T2ByJ-00022v-U1; Thu, 16 Aug 2012 22:07:35 -0400
Date: Thu, 16 Aug 2012 22:07:35 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Dmitriy Igrishin <dmitigr@gmail.com>
Cc: pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: Clarification suggestion for 46.4 chapter.
Message-ID: <20120817020735.GQ30286@momjian.us>
References: 
 <CAAfz9KN4PEf0QodA_F37M6RifK2sMXR8bjAgUqGuNKqOdVchXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="mvpLiMfbWzRoNl4x"
Content-Disposition: inline
In-Reply-To: 
 <CAAfz9KN4PEf0QodA_F37M6RifK2sMXR8bjAgUqGuNKqOdVchXw@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201208/29
X-Sequence-Number: 7422


--mvpLiMfbWzRoNl4x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec  5, 2011 at 02:53:22PM +0300, Dmitriy Igrishin wrote:
> Hey,
> 
> The section 46.4 describes the base data types used in messages.
> http://www.postgresql.org/docs/9.1/static/protocol-message-types.html
> 
> According to section 46.5
> http://www.postgresql.org/docs/9.1/static/protocol-message-formats.html
> there are cases when Int32 can be negative (e.g. see DataRow(B) message
> description.)
> 
> Thus, I would like to suggest to change the description of Int(i)
> from
> "An n-bit integer in network byte order ..."
> to
> "An n-bit signed integer in network byte order ..."

OK, documentation updated.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--mvpLiMfbWzRoNl4x
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="int.diff"

diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
new file mode 100644
index e725563..8778c58
*** a/doc/src/sgml/protocol.sgml
--- b/doc/src/sgml/protocol.sgml
*************** This section describes the base data typ
*** 1819,1825 ****
  </term>
  <listitem>
  <para>
!                 An <replaceable>n</replaceable>-bit integer in network byte
                  order (most significant byte first).
                  If <replaceable>i</replaceable> is specified it
                  is the exact value that will appear, otherwise the value
--- 1819,1825 ----
  </term>
  <listitem>
  <para>
!                 An <replaceable>n</replaceable>-bit signed integer in network byte
                  order (most significant byte first).
                  If <replaceable>i</replaceable> is specified it
                  is the exact value that will appear, otherwise the value

--mvpLiMfbWzRoNl4x--