public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: CREATE TABLE LIKE, regarding constraints
Date: Sun, 26 Aug 2012 16:35:19 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevEy-+Tszne6SgkHm05dyRkPV0tVGRqTT=Dj9G7Fe9gfFwQ@mail.gmail.com>
References: <[email protected]>
<CABUevExTjCDGhskyXid+6pHSoatUO2u0L7zJ-jAJf43WaLMmtg@mail.gmail.com>
<[email protected]>
<CABUevEy-+Tszne6SgkHm05dyRkPV0tVGRqTT=Dj9G7Fe9gfFwQ@mail.gmail.com>
On Mon, Jan 2, 2012 at 08:31:43PM +0100, Magnus Hagander wrote:
> On Mon, Jan 2, 2012 at 15:32, <[email protected]> wrote:
> > On Fri, Dec 30, 2011 at 22:27, <[email protected]> wrote:
> >> www.postgresql.org/docs/9.0/static/sql-createtable.html
> >> == == == == ==
> >> LIKE parent_table [ like_option ... ]
> >> . . .
> >> Not-null constraints are always copied to the new table.
> >> CHECK constraints will only be copied if INCLUDING CONSTRAINTS is specified; other types of constraints will never be copied.
> >> . . .
> >> == == == == ==
> >>
> >> But I do see PK and UNIQUE constraints
> >> CONSTRAINT blah_pkey PRIMARY KEY (id),
> >> CONSTRAINT blah_host_id_key UNIQUE (host_id)
> >> in the def of the new table.
> >
> > Can you provide the commands you ran to make that happen? It doesn't
> > happen for me in a trivial test.
> >
> >> Also, why is there no discussion of what "EXCLUDING CONSTRAINTS" will result in ?
> >
> >
> > Magnus,
> > I did some more "testing" of CREATE TABLE LIKE,
> > and now see that [INCLUDING INDEXES] also can cause PRIMARY KEY and UNIQUE constraints to become part of the new table.
>
> Ah, that explains why I couldn't reproduce it.
>
>
> > I have no problem with this behavior,
> > but the doc probably deserves some clarification on the "relationship" between
> > [INCLUDING CONSTRAINTS] and [INCLUDING INDEXES].
>
> That might be a good idea, yes. Feel like cooking up a patch?
I have applied the attached patch based on this report.
It is confusing that INCLUDING CONSTRAINTS only copies CHECK
constraints, and INCLUDING INDEXES is required for PRIMARY KEY and
UNIQUE constraints. Is there a reason our logic is so odd here? The
SQL standard?
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachments:
[text/x-diff] constraints.diff (1.8K, 2-constraints.diff)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
new file mode 100644
index 19e6f8e..445ca40
*** a/doc/src/sgml/ref/create_table.sgml
--- b/doc/src/sgml/ref/create_table.sgml
*************** CREATE [ [ GLOBAL | LOCAL ] { TEMPORARY
*** 336,351 ****
</para>
<para>
Not-null constraints are always copied to the new table.
! <literal>CHECK</literal> constraints will only be copied if
! <literal>INCLUDING CONSTRAINTS</literal> is specified; other types of
! constraints will never be copied. Also, no distinction is made between
! column constraints and table constraints — when constraints are
! requested, all check constraints are copied.
! </para>
! <para>
! Any indexes on the original table will not be created on the new
! table, unless the <literal>INCLUDING INDEXES</literal> clause is
! specified.
</para>
<para><literal>STORAGE</> settings for the copied column definitions will only
be copied if <literal>INCLUDING STORAGE</literal> is specified. The
--- 336,348 ----
</para>
<para>
Not-null constraints are always copied to the new table.
! <literal>CHECK</literal> constraints will be copied only if
! <literal>INCLUDING CONSTRAINTS</literal> is specified.
! Indexes, <literal>PRIMARY KEY</>, and <literal>UNIQUE</> constraints
! on the original table will be created on the new table only if the
! <literal>INCLUDING INDEXES</literal> clause is specified.
! No distinction is made between column constraints and table
! constraints.
</para>
<para><literal>STORAGE</> settings for the copied column definitions will only
be copied if <literal>INCLUDING STORAGE</literal> is specified. The
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: CREATE TABLE LIKE, regarding constraints
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox