Received: from magus.postgresql.org ([87.238.57.229])
	by malur.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T7DNZ-0003j2-HH
	for pgsql-docs@postgresql.org; Thu, 30 Aug 2012 22:38:25 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <bruce@momjian.us>) id 1T7DNX-0006zq-Cg
	for pgsql-docs@postgresql.org; Thu, 30 Aug 2012 22:38:25 +0000
Received: from bruce by momjian.us with local (Exim 4.72)
	(envelope-from <bruce@momjian.us>)
	id 1T7DNV-0001BX-OS; Thu, 30 Aug 2012 18:38:21 -0400
Date: Thu, 30 Aug 2012 18:38:21 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Josh Kupershmidt <schmiddy@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: pgtesttiming.sgml, FreeBSD command output
Message-ID: <20120830223821.GG32350@momjian.us>
References: 
 <CAK3UJRHJvGJZW80S3=5HJ0TMG5QmkXH5YaTS2K_0-9kQKP-a5g@mail.gmail.com>
	<1341606781.7092.0.camel@vanquo.pezone.net>
	<CAK3UJRFe51f_4Sc0a-QK6uTsXLMHtyV7cmKQJX13gAbs0qVGCw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
In-Reply-To: 
 <CAK3UJRFe51f_4Sc0a-QK6uTsXLMHtyV7cmKQJX13gAbs0qVGCw@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Pg-Spam-Score: -2.1 (--)
X-Archive-Number: 201208/57
X-Sequence-Number: 7450


--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


Patch attached and applied for PG 9.3.

---------------------------------------------------------------------------

On Fri, Jul  6, 2012 at 02:09:00PM -0700, Josh Kupershmidt wrote:
> On Fri, Jul 6, 2012 at 1:33 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > On fre, 2012-07-06 at 13:21 -0700, Josh Kupershmidt wrote:
> 
> >> <screen>
> >> dmesg | grep "Timecounter"
> >> sysctl kern.timecounter.hardware=TSC
> >> </screen>
> >>
> >> First, grep is case-sensitive by default, so that line of output
> >> shouldn't have matched at all, right?
> >
> > I don't think this was meant to say that the second line is the output
> > of the first.  I read this as two separate commands.  But I agree this
> > part is a bit unclear.
> 
> Oh, I see now. The <screen> sections above and below that one were
> including output, and I was just expecting the same here.
> 
> One way to fix would be to include shell prompts and outputs for both
> commands (patch Option 1, attached).  Or, if we don't want to bother
> including output, as the section does now, maybe we could at least
> include the shell prompts and mention that output is excluded (patch
> Option 2).
> 
> I've also attached an unrelated typofix I noticed for the same page.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--bp/iNruPH9dso1Pn
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="timer.diff"

diff --git a/doc/src/sgml/pgtesttiming.sgml b/doc/src/sgml/pgtesttiming.sgml
new file mode 100644
index 45ee80c..a2581d2
*** a/doc/src/sgml/pgtesttiming.sgml
--- b/doc/src/sgml/pgtesttiming.sgml
*************** Histogram of timing durations:
*** 183,190 ****
     information about the timer selected during boot:
  
  <screen>
! dmesg | grep "Timecounter"
! sysctl kern.timecounter.hardware=TSC
  </screen>
    </para>
  
--- 183,195 ----
     information about the timer selected during boot:
  
  <screen>
! # dmesg | grep "Timecounter"
! Timecounter "ACPI-fast" frequency 3579545 Hz quality 900
! Timecounter "i8254" frequency 1193182 Hz quality 0
! Timecounters tick every 10.000 msec
! Timecounter "TSC" frequency 2531787134 Hz quality 800
! # sysctl kern.timecounter.hardware=TSC
! kern.timecounter.hardware: ACPI-fast -> TSC
  </screen>
    </para>
  
*************** Histogram of timing durations:
*** 277,283 ****
    </para>
  
    <para>
!    Timers used on older PC hardware including the 8254 Programmable Interval
     Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
     Controller (APIC) timer, and the Cyclone timer.  These timers aim for
     millisecond resolution.
--- 282,288 ----
    </para>
  
    <para>
!    Timers used on older PC hardware include the 8254 Programmable Interval
     Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
     Controller (APIC) timer, and the Cyclone timer.  These timers aim for
     millisecond resolution.

--bp/iNruPH9dso1Pn--