Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WE4RX-0005R8-Au for pgsql-docs@arkaria.postgresql.org; Thu, 13 Feb 2014 22:07:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1WE4RW-0000b3-Rg for pgsql-docs@arkaria.postgresql.org; Thu, 13 Feb 2014 22:07:38 +0000 Received: from makus.postgresql.org ([2001:4800:7903:4::125]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WE4RW-0000ax-2L for pgsql-docs@postgresql.org; Thu, 13 Feb 2014 22:07:38 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WE4RT-0006NQ-B7 for pgsql-docs@postgresql.org; Thu, 13 Feb 2014 22:07:37 +0000 Received: from bruce by momjian.us with local (Exim 4.72) (envelope-from ) id 1WE4RO-0006UF-Db; Thu, 13 Feb 2014 17:07:30 -0500 Date: Thu, 13 Feb 2014 17:07:30 -0500 From: Bruce Momjian To: Marc Mamin Cc: Peter Eisentraut , "'pgsql-docs@postgresql.org'" Subject: Re: misleading lang_name case in CREATE FUNCTION doc. Message-ID: <20140213220730.GH32126@momjian.us> References: <1384343764.15453.4.camel@vanquo.pezone.net> <5294E92E.1020304@gmx.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3siQDZowHQqNOShm" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org --3siQDZowHQqNOShm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 26, 2013 at 07:28:17PM +0000, Marc Mamin wrote: > > >Von: Peter Eisentraut [peter_e@gmx.net] > > >>On 11/13/13, 9:02 AM, Marc Mamin wrote: > >> something like :? > >> > >> The name of the language that the function is implemented in. > >> Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language. > >> Single quotes are optional, they required correct case when used. > > >That would make the deprecated syntax more prominent than the > >non-deprecated one. We want to get rid of the single quotes. > > Ok, next try :) > > The name of the language that the function is implemented in. > Can be sql, c, internal, or the name of a user-defined procedural language. > Single quotes are deprecated. They require correct case when used. I have applied the attached patch to improve the wording. Thanks for the report. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + --3siQDZowHQqNOShm Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="lang.diff" diff --git a/doc/src/sgml/ref/create_function.sgml b/doc/src/sgml/ref/create_function.sgml new file mode 100644 index 81278bb..b61b978 *** a/doc/src/sgml/ref/create_function.sgml --- b/doc/src/sgml/ref/create_function.sgml *************** CREATE [ OR REPLACE ] FUNCTION *** 252,261 **** The name of the language that the function is implemented in. ! Can be SQL, C, internal, or the name of a user-defined ! procedural language. For backward compatibility, ! the name can be enclosed by single quotes. --- 252,261 ---- The name of the language that the function is implemented in. ! It can be sql, c, internal, or the name of a user-defined ! procedural language, e.g. plpgsql. Enclosing the ! name in single quotes is deprecated and requires matching case. --3siQDZowHQqNOShm Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs --3siQDZowHQqNOShm--