Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8095=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XRoN6-0001KK-Va
 for pgsql-docs@arkaria.postgresql.org; Wed, 10 Sep 2014 20:20:09 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8095=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XRoN6-0002r1-FO
 for pgsql-docs@arkaria.postgresql.org; Wed, 10 Sep 2014 20:20:08 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <bruce@momjian.us>) id 1XRoN5-0002pS-3H
 for pgsql-docs@postgresql.org; Wed, 10 Sep 2014 20:20:07 +0000
Received: from momjian.us ([72.94.173.45])
 by makus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.80) (envelope-from <bruce@momjian.us>) id 1XRoN1-000118-Hs
 for pgsql-docs@postgresql.org; Wed, 10 Sep 2014 20:20:05 +0000
Received: from bruce by momjian.us with local (Exim 4.72)
 (envelope-from <bruce@momjian.us>)
 id 1XRoN0-0007hz-5j; Wed, 10 Sep 2014 16:20:02 -0400
Date: Wed, 10 Sep 2014 16:20:02 -0400
From: Bruce Momjian <bruce@momjian.us>
To: David Johnston <david.g.johnston@gmail.com>
Cc: "pgsql-docs@postgresql.org" <pgsql-docs@postgresql.org>
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in
 Server Configuration?
Message-ID: <20140910202002.GA21173@momjian.us>
References: <1400698826956-5804655.post@n5.nabble.com>
 <2916.1400704666@sss.pgh.pa.us>
 <CAKFQuwbjqT7jHAULPM0YB7x=+qpddH5bYnGmwZ+yVhNBb6SVnQ@mail.gmail.com>
 <CAKFQuwa5d3EUBGwYN1mA6FKO1K7kO+Wci8yM57QNHdEGQ9TJ9g@mail.gmail.com>
 <CAKFQuwbbOZRqmnx-XRyd+viT+MCAH6TVc0yn1aJtG5MdSNAWpA@mail.gmail.com>
 <20140909191317.GF16663@momjian.us>
 <CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="XsQoSWH+UP9D9v3l"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Pg-Spam-Score: -4.4 (----)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org


--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, Sep  9, 2014 at 03:40:45PM -0400, David Johnston wrote:
> Minor corrections:
> 
> ​First block: "
> In the first section of this chapter, we
>  describe how to set configuration parameters"​
>  
> ​- remove the comma
> 
> ​Second Block: 
> - placement of the colon inside or outside of the emphasis tag is inconsistent
> (string, unit, enum are inside; boolean and ​numeric are outside)
> - units:  "An numeric value..." -> maybe "An unadorned numeric value...
> 
> ​Third block:
> ​"Hash marks (<literal>#</literal>) designate the remainder of lines as
> comments." -> "...designate the remainder of the line as a comment."  I read
> this at first as "remaining lines [in the file] ... "
> 
> "To embed a single quote in a parameter value, write either two quotes
> (preferred) or backslash-quote." -> remove the comma
> "Querying this view is the sames as" -> "the same as"

I agree all of the above are improvements, and changed.

> "In addition to setting global defaults or attaching" <- add a comma after
> "defaults"

I didn't like this change as it causes too many comma phrases.

Attaches are the changes since yesterday's patch.  The full patch is at:

	ftp://momjian.us/postgresql/mypatches/config.diff

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

--XsQoSWH+UP9D9v3l
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="change.diff"

commit 01cbe3a4949664f3b001a7d3be7990d37fc8a291
Author: Bruce Momjian <bruce@momjian.us>
Date:   Wed Sep 10 15:49:06 2014 -0400

    dummy commit

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
new file mode 100644
index 156c264..4a97855
*** a/doc/src/sgml/config.sgml
--- b/doc/src/sgml/config.sgml
***************
*** 10,16 ****
  
    <para>
     There are many configuration parameters that affect the behavior of
!    the database system. In the first section of this chapter, we
     describe how to interact with configuration parameters. The subsequent sections
     discuss each parameter in detail.
    </para>
--- 10,16 ----
  
    <para>
     There are many configuration parameters that affect the behavior of
!    the database system. In the first section of this chapter we
     describe how to interact with configuration parameters. The subsequent sections
     discuss each parameter in detail.
    </para>
***************
*** 31,37 ****
  
       <listitem>
        <para>
!        <emphasis>Boolean</emphasis>: Values can be written as
         <literal>on</literal>,
         <literal>off</literal>,
         <literal>true</literal>,
--- 31,37 ----
  
       <listitem>
        <para>
!        <emphasis>Boolean:</emphasis> Values can be written as
         <literal>on</literal>,
         <literal>off</literal>,
         <literal>true</literal>,
***************
*** 54,61 ****
  
       <listitem>
        <para>
!        <emphasis>Numeric</emphasis> (integer and floating point): Do not use
!        single-quotes (unless otherwise required) or thousand separators.
        </para>
       </listitem>
  
--- 54,62 ----
  
       <listitem>
        <para>
!        <emphasis>Numeric (integer and floating point):</emphasis> Do
!        not use single-quotes (unless otherwise required) or thousand
!        separators.
        </para>
       </listitem>
  
***************
*** 64,71 ****
         <emphasis>Numeric or String with Unit (Memory &amp;
         Time):</emphasis> These have an implicit unit, which is
         either kilobytes, blocks (typically eight kilobytes),
!        milliseconds, seconds, or minutes.  An numeric value
!        will use the default, which can be found by referencing
         <structname>pg_settings</>.<structfield>unit</>.  For convenience,
         a different unit can also be specified explicitly via a string
         value. It is case-sensitive and may include whitespace between
--- 65,72 ----
         <emphasis>Numeric or String with Unit (Memory &amp;
         Time):</emphasis> These have an implicit unit, which is
         either kilobytes, blocks (typically eight kilobytes),
!        milliseconds, seconds, or minutes.  A unadorned numeric
!        value will use the default, which can be found by referencing
         <structname>pg_settings</>.<structfield>unit</>.  For convenience,
         a different unit can also be specified explicitly via a string
         value. It is case-sensitive and may include whitespace between
*************** log_destination = 'syslog'
*** 123,134 ****
  search_path = '"$user", public'
  shared_buffers = 128MB
  </programlisting>
!      One parameter is specified per line. The equal sign between name
!      and value is optional. Whitespace is insignificant and blank
!      lines are ignored. Hash marks (<literal>#</literal>) designate the
!      remainder of lines as comments.  Parameter values that are not simple
       identifiers or numbers must be single-quoted.  To embed a single
!      quote in a parameter value, write either two quotes (preferred)
       or backslash-quote.
      </para>
  
--- 124,135 ----
  search_path = '"$user", public'
  shared_buffers = 128MB
  </programlisting>
!      One parameter is specified per line. The equal sign between name and
!      value is optional. Whitespace is insignificant and blank lines are
!      ignored. Hash marks (<literal>#</literal>) designate the remainder
!      of the line as a comment.  Parameter values that are not simple
       identifiers or numbers must be single-quoted.  To embed a single
!      quote in a parameter value write either two quotes (preferred)
       or backslash-quote.
      </para>
  
*************** shared_buffers = 128MB
*** 229,235 ****
      <itemizedlist>
       <listitem>
        <para>
!        Querying this view is the sames as <command>SHOW</> but provides
         more detail, as well as allowing for joins against other relations
         and the specification of filter criteria.
        </para>
--- 230,236 ----
      <itemizedlist>
       <listitem>
        <para>
!        Querying this view is the same as <command>SHOW</> but provides
         more detail, as well as allowing for joins against other relations
         and the specification of filter criteria.
        </para>

--XsQoSWH+UP9D9v3l
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--XsQoSWH+UP9D9v3l--