Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8098=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XRsaL-0001XZ-0C
 for pgsql-docs@arkaria.postgresql.org; Thu, 11 Sep 2014 00:50:05 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8098=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XRsaJ-0004AL-VR
 for pgsql-docs@arkaria.postgresql.org; Thu, 11 Sep 2014 00:50:04 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <bruce@momjian.us>) id 1XRsaJ-0004AC-0E
 for pgsql-docs@postgresql.org; Thu, 11 Sep 2014 00:50:03 +0000
Received: from momjian.us ([72.94.173.45])
 by makus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.80) (envelope-from <bruce@momjian.us>) id 1XRsaG-00064T-16
 for pgsql-docs@postgresql.org; Thu, 11 Sep 2014 00:50:01 +0000
Received: from bruce by momjian.us with local (Exim 4.72)
 (envelope-from <bruce@momjian.us>)
 id 1XRsaD-0005Zy-Uc; Wed, 10 Sep 2014 20:49:57 -0400
Date: Wed, 10 Sep 2014 20:49:57 -0400
From: Bruce Momjian <bruce@momjian.us>
To: David Johnston <david.g.johnston@gmail.com>
Cc: "pgsql-docs@postgresql.org" <pgsql-docs@postgresql.org>
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in
 Server Configuration?
Message-ID: <20140911004957.GE16199@momjian.us>
References: <1400698826956-5804655.post@n5.nabble.com>
 <2916.1400704666@sss.pgh.pa.us>
 <CAKFQuwbjqT7jHAULPM0YB7x=+qpddH5bYnGmwZ+yVhNBb6SVnQ@mail.gmail.com>
 <CAKFQuwa5d3EUBGwYN1mA6FKO1K7kO+Wci8yM57QNHdEGQ9TJ9g@mail.gmail.com>
 <CAKFQuwbbOZRqmnx-XRyd+viT+MCAH6TVc0yn1aJtG5MdSNAWpA@mail.gmail.com>
 <20140909191317.GF16663@momjian.us>
 <CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>
 <20140910202002.GA21173@momjian.us>
 <CAKFQuwZ2-3k2h0Z6YJ0EbZRNVZtVQUAedccQGJ9JFMqSVeJJ1A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKFQuwZ2-3k2h0Z6YJ0EbZRNVZtVQUAedccQGJ9JFMqSVeJJ1A@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Pg-Spam-Score: -4.4 (----)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

On Wed, Sep 10, 2014 at 08:09:30PM -0400, David Johnston wrote:
> On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian <bruce@momjian.us> wrote:
> 
>     On Tue, Sep  9, 2014 at 03:40:45PM -0400, David Johnston wrote:
> 
>     > "In addition to setting global defaults or attaching" <- add a comma
>     after
>     > "defaults"
> 
>     I didn't like this change as it causes too many comma phrases.
> 
>     Attaches are the changes since yesterday's patch.  The full patch is at:
> 
>             ftp://momjian.us/postgresql/mypatches/config.diff
> 
> 
> 
> ​At minimum the word "setting" in that paragraph needs to be made plural. ",
> you can pass settings to <productname>PostgreSQL..."​

Oh, good point, fixed.

> ​I'm not particularly fond of the overly long preamble burying the "shell
> facilities" - and the resultant comma separating the two - but cannot think of
> anything better.  Not having the transition makes it too short and curt.  The
> proposed second comma helped to at least break it up but it too doesn't sound
> all that great.
> 
> I'm good for just making the plural fix and calling it a day.

Modified patch applied to head and 9.4.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs