Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YxmfB-0005XZ-Uq for pgsql-docs@arkaria.postgresql.org; Thu, 28 May 2015 01:31:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YxmfA-0007Mk-W3 for pgsql-docs@arkaria.postgresql.org; Thu, 28 May 2015 01:31:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1Yxmf7-0007FY-GV for pgsql-docs@postgresql.org; Thu, 28 May 2015 01:31:09 +0000 Received: from smtprelay0086.b.hostedemail.com ([64.98.42.86] helo=smtprelay.b.hostedemail.com) by makus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1Yxmf4-0006P9-1Q for pgsql-docs@postgresql.org; Thu, 28 May 2015 01:31:08 +0000 Received: from filter.hostedemail.com (10.5.19.248.rfc1918.com [10.5.19.248]) by smtprelay01.b.hostedemail.com (Postfix) with ESMTP id 6953D2D2A11; Thu, 28 May 2015 01:31:05 +0000 (UTC) X-Session-Marker: 616C76686572726540616C76682E6E6F2D69702E6F7267 X-Spam-Summary: 50, 0, 0, , d41d8cd98f00b204, alvherre@alvh.no-ip.org, :::, RULES_HIT:41:355:379:599:960:967:973:988:989:1260:1263:1277:1311:1312:1313:1314:1345:1359:1437:1515:1516:1518:1519:1534:1540:1593:1594:1595:1596:1711:1730:1747:1777:1792:1981:2194:2199:2393:2525:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4605:4659:5007:6261:9025:9121:10004:10400:10848:11232:11256:11257:11658:11914:12296:12517:12519:13069:13311:13357:13894:13895:21080:21094, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-HE-Tag: self77_60baf9edac214 X-Filterd-Recvd-Size: 1719 Received: from alvin.alvh.no-ip.org (unknown [186.37.86.212]) (Authenticated sender: alvherre@alvh.no-ip.org) by omf08.b.hostedemail.com (Postfix) with ESMTPA; Thu, 28 May 2015 01:31:04 +0000 (UTC) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 84304528; Wed, 27 May 2015 22:31:01 -0300 (CLT) Date: Wed, 27 May 2015 22:31:01 -0300 From: Alvaro Herrera To: "Joshua D. Drake" Cc: pgsql-docs Subject: Re: per feedback I received directly, pg_dump manpage patch Message-ID: <20150528013101.GG5885@postgresql.org> References: <55665072.9020409@commandprompt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55665072.9020409@commandprompt.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org Joshua D. Drake wrote: > The man page does not clearly state that pg_dump will not dump things like > users or roles. It does mention briefly in the notes section that pg_dumpall > is needed for items that are set via SET but that isn't very clear on the > other items. I agree that we need a warning about this, but I think it should be a bit more generic rather than focused exclusively on pg_dumpall; perhaps something like "global objs such as roles/tblspcs should be backed up separately, for example using pg_dumpall". I didn't check the location of the warning in your patch, or whether a warning is really appropriate rather than, say, or a plain . -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs