public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Joshua D. Drake <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: per feedback I received directly, pg_dump manpage patch
Date: Wed, 27 May 2015 22:53:12 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

Joshua D. Drake wrote:
> 
> On 05/27/2015 06:31 PM, Alvaro Herrera wrote:
> >
> >Joshua D. Drake wrote:
> >>The man page does not clearly state that pg_dump will not dump things like
> >>users or roles. It does mention briefly in the notes section that pg_dumpall
> >>is needed for items that are set via SET but that isn't very clear on the
> >>other items.
> >
> >I agree that we need a warning about this, but I think it should be a
> >bit more generic rather than focused exclusively on pg_dumpall; perhaps
> >something like "global objs such as roles/tblspcs should be backed up
> >separately, for example using pg_dumpall".
> 
> As the only way to back up global objects is pg_dumpall....?

Well, my point is that the roles could be set up separately by other
means.

> >I didn't check the location of the warning in your patch, or whether a
> >warning is really appropriate rather than, say, <note> or a plain
> ><para>.
> 
> The warning is directly after the first paragraph. I thought about using
> <note> but I think this does warrant a <warning>. You can't actually restore
> a database correctly without pg_dump + pg_dumpall (in this context).

Okay, +0 there.  (That is, I don't disagree with you but I won't stand
in the way of others disagreeing on that point.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: per feedback I received directly, pg_dump manpage patch
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox