Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zb6Qj-0002Nx-8R for pgsql-hackers@arkaria.postgresql.org; Sun, 13 Sep 2015 12:30:49 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zb6Qi-0001hH-KP for pgsql-hackers@arkaria.postgresql.org; Sun, 13 Sep 2015 12:30:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zb6Qh-0001h3-RP for pgsql-hackers@postgresql.org; Sun, 13 Sep 2015 12:30:47 +0000 Received: from tamriel.snowman.net ([2001:4830:167b::11]) by magus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1Zb6Qa-0004Kr-5c for pgsql-hackers@postgresql.org; Sun, 13 Sep 2015 12:30:46 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 3A2E25F7B0; Sun, 13 Sep 2015 08:30:39 -0400 (EDT) Date: Sun, 13 Sep 2015 08:30:38 -0400 From: Stephen Frost To: Charles Clavadetscher Cc: pgsql-hackers@postgresql.org Subject: Re: [DOCS] Missing COMMENT ON POLICY Message-ID: <20150913123038.GF3685@tamriel.snowman.net> References: <016a01d0ede6$1fc6af00$5f540d00$@swisspug.org> <016c01d0edec$81975df0$84c619d0$@swisspug.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gMek43rMOMY8//NQ" Content-Disposition: inline In-Reply-To: <016c01d0edec$81975df0$84c619d0$@swisspug.org> X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-61-generic (x86_64) X-Uptime: 08:24:44 up 39 days, 20:55, 6 users, load average: 0.12, 0.13, 0.14 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --gMek43rMOMY8//NQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Charles, * Charles Clavadetscher (clavadetscher@swisspug.org) wrote: > Well I gave it a try. I am still not very well aware how the process for > suggesting or submitting corrections work, but this is as far as I got. > In the attachment is a patch for the missing entry for POLICY in the > documentation on COMMENT that I mentioned earlier on pgsql-docs. Thanks! This looks mostly correct but only goes half-way (not that there's a lot to this change ;). The 'policy_name' parameter which is added should also be added to the 'Parameters' list below, and the description under 'table_name' updated to reflect that it's used for policies also. There should probably be an example added also, since it looks like there are examples of pretty much all the other COMMENT ON types. Thanks again! Stephen --gMek43rMOMY8//NQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJV9WxuAAoJEO1sijiDR2RV9cEP/ieTiAPFVkZ2aOPlYrPOu1XF 8dL/ZnAYkaQY6BPnU7vOAFbpppoRgvLkjc1LaQwUazIMFNVrU+ldp4hKCDTvflm6 vRKIXu51Sf5UBK3dys7AWnv1tUCvxnmTcjB/Yo2EDhdfnsUeFr0lBERKS8fuJQTL 626V3KOje/WVI31UTyZ6gfG7z12GcwseoPigZmJUYfeZqdYUCInCOMzu/nYK3HzZ S7ndBlWz70dc+BiqNI+CKVaLFLrpycRIaooRnT8PWrhCEUdSqj0TQUEEca5oxGy5 X1XKKbf5mBM1dcsC/JqPbk8tQDPHPFBE4XT54qk2cV/afnRDARvABQb/dYFr95oN u/6U6Oo3n+wgfBEeobMHgo7I06V+XgAa5rC2g+ouPRdS7kpwtRpZ4GiN0m2FWbn/ bSeDa/6d/A3I8iNXkdAP4iAX0r9iJvgf+6yZFkmt6dwccUOxg6a6Li+s2eyaJ4LO FG4kPuGK0b3J0oHYjxQa9y6cWbcmEp9GYO8vbZaV2UD750gFxc6GV972IToT/4NP GdgFuJUIhlwJMYLaktfh3pzGPf7WhjE/wNQw9rSx44i+vhxdvU0sJ5z//rhl1uvP ZL80YMK9lGPbSskBfEkSn3CUIZcTjBAdXbm+5WL2VnAhF5o4iOW6DLViXLRQtP5O 64B+SdmRah8zaII1edgD =bdhd -----END PGP SIGNATURE----- --gMek43rMOMY8//NQ--