Date: Sun, 13 Sep 2015 10:56:05 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Charles Clavadetscher <clavadetscher@swisspug.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [DOCS] Missing COMMENT ON POLICY
Message-ID: <20150913145605.GI3685@tamriel.snowman.net>
References: <016a01d0ede6$1fc6af00$5f540d00$@swisspug.org>
 <016c01d0edec$81975df0$84c619d0$@swisspug.org>
 <20150913123038.GF3685@tamriel.snowman.net>
 <01e601d0ee21$aa4deef0$fee9ccd0$@swisspug.org>
 <20150913124934.GH3685@tamriel.snowman.net>
 <55F579A2.4080801@swisspug.org> <55F58771.7040001@swisspug.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="idWhmhIw+yKNYPBd"
Content-Disposition: inline
In-Reply-To: <55F58771.7040001@swisspug.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--idWhmhIw+yKNYPBd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Charles,

* Charles Clavadetscher (clavadetscher@swisspug.org) wrote:
> I noticed that the position of the parameter "policy_name" in the
> description list of parameters was not at the (alphabetically)
> correct position. I changed that and the result is attached.

Thanks!

> I think/hope that is now all correct.

We generally prefer one complete patch which represents the total set
of changes to a lot of individual little patches which build on each
other.

If you're using git and have these patches on a branch as different
commits, you can do an interactive rebase to squash them all together,
like this:

git rebase -i

That will open an editor and then you can choose the action to take for
each patch.  Generally, I'll make the first patch 'reword' and the
rest 'squash'.  Saving and exiting the editor will then take you to
another editor session where you'll have an opportunity to reword the
commit message (to incorporate all of the changes).

Once all of that's done, you can use 'git format-patch' to create a file
which includes the commit message and the patch.  I generally run it
like so:

git format-patch @{u} --stdout > ~/patches/filename-for-patch.patch

Hopefully that helps.

Thanks!

Stephen

--idWhmhIw+yKNYPBd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJV9Y6EAAoJEO1sijiDR2RVUKkQAMHg70YdJsDJ/wkwhNH8kfHr
MwwHVAX1wjzYpkcCP+5MTYThZTGRsW4g831ltmTsLHzvO//wUV0Q67Kw7eMeFCxN
qiMCVFf5GOChBw5MFZtYbMPkFxZj6arRk3ONS+PgG1CrSUYGT/a09tl+Rod1tu9w
vYqJJWyVBzdVLs7SNshlFyFmuGHl5m7s+MBq8A1UAJb+cplUjg5RxBKu6zTpv51J
01jIw5bK0y02hsRW7/lHkZas4s/Ij4jAScYZ5E+6avawaCYNBTy3oWjjsJZA7Ina
WUM0L+yebwRN0McMrLyHNMS6f501MluU7twU46kppo13PTxILu1uNrUNuU9s2YP7
1xQ8sNj8VlP2aqqQZkS6du16FWy4FtkQUiizm7gegXneSqZVWiD9fM4UKJ7XiQuK
x5tXODNJXKru68BF5ULO4EkEyNoiQyZcfp4HFoqrlSE+egkrnnx6V9roWhMG934S
U4SaTQ9Bh9bR16fl5xyW05kuyQ2her0D6Kst3u0Pvq+/MxKh7YAoRdKPv6Y67sLj
+qN0646LBYmzbtZSJxRvj+h2EcS0XbUHL/2aAO3Ufg75WIrBOOQ/apQ+cynnQ98B
keVMH3CVlm2XZWBAUsFixcRkHUvAbN1kfYZdUaR/IP+qFxPCZ3xXzgFhZk2c/LrE
gaVVV488mW3x8d4S05fc
=j45K
-----END PGP SIGNATURE-----

--idWhmhIw+yKNYPBd--