Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZhiLe-0002Gi-6D for pgsql-docs@arkaria.postgresql.org; Thu, 01 Oct 2015 18:12:54 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZhiLd-0004Zr-IP for pgsql-docs@arkaria.postgresql.org; Thu, 01 Oct 2015 18:12:53 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZhiLc-0004ZM-JS; Thu, 01 Oct 2015 18:12:52 +0000 Received: from smtp-auth.no-ip.com ([8.23.224.61] helo=out.smtp-auth.no-ip.com) by makus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZhiLY-0007Dl-0r; Thu, 01 Oct 2015 18:12:50 +0000 X-No-IP: alvh.no-ip.org@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from alvin.alvh.no-ip.org (unknown [200.104.52.149]) (Authenticated sender: alvh.no-ip.org@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 12DC240133C; Thu, 1 Oct 2015 11:12:42 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 3FAD91AF4; Thu, 1 Oct 2015 15:12:40 -0300 (CLT) Date: Thu, 1 Oct 2015 15:12:40 -0300 From: Alvaro Herrera To: Fujii Masao Cc: oonishitk@nttdata.co.jp, pgsql-docs , PostgreSQL-development Subject: Re: max_worker_processes on the standby Message-ID: <20151001181240.GT2573@alvherre.pgsql> References: <20150930224806.GR2573@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org Fujii Masao wrote: > I've not read the patch yet, but the patched server with track_commit_timestamp > enabled caused the following PANIC error when I ran pgbench. Ah, that was a stupid typo: I used || instead of &&. Fixed that. I also changed DeactivateCommitTs() so that it removes all slru segments instead of leaving the last one around (which is what SimpleLruTruncate was doing). This was noticeable when you ran a server with the feature enabled (which created some files), then disabled it (which removed all but the last) and ran for some more xacts; then enabled it again (which created a new file, far ahead from the previously existing one). Since the feature has enough protections that it doesn't have a problem with no files at all being present, this works correctly. Note no wal-logging of this operation: it's not necessary AFAICS because the same deactivation routine would be called again in recovery and in XLOG_PARAMETER_CHANGE, so it should be safe. And pushed. Thanks! -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs