Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-docs-owner+M9059=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
	id 1cR9kX-0000as-DB
	for pgsql-docs@arkaria.postgresql.org; Wed, 11 Jan 2017 03:38:57 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-docs-owner+M9059=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
	id 1cR9kX-0004HL-0E
	for pgsql-docs@arkaria.postgresql.org; Wed, 11 Jan 2017 03:38:57 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1cR9kW-0004Gv-EB
	for pgsql-docs@postgresql.org; Wed, 11 Jan 2017 03:38:56 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1cR9kT-0002ty-S6
	for pgsql-docs@postgresql.org; Wed, 11 Jan 2017 03:38:55 +0000
Received: from bruce by momjian.us with local (Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1cR9kT-0002t3-9Q; Tue, 10 Jan 2017 22:38:53 -0500
Date: Tue, 10 Jan 2017 22:38:53 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL-documentation <pgsql-docs@postgresql.org>
Subject: Re: pg_xlogdump -p option correction
Message-ID: <20170111033853.GA8584@momjian.us>
References: <20161226215604.GA24784@momjian.us>
 <CAB7nPqTW2iH70tJkhu8U9AUmVKB43gR0FvODmctqS=+fjuuzhA@mail.gmail.com>
 <20170107010257.GB3164@momjian.us>
 <CAB7nPqRAFVTuJOPivPwGXH_P+7gXWT6wZg2UTE28Uo8mRciUBQ@mail.gmail.com>
 <20170107162059.GE3164@momjian.us>
 <CAB7nPqRxDcgzuw3GMm2ys1wH+emPvN7fF5h=ND04Y0hu+ginbw@mail.gmail.com>
 <20170109193223.GA19680@momjian.us>
 <CAB7nPqThD73UUSwOfpGdk0k36XmNGea9jLss02fbyHf7KWcSzw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAB7nPqThD73UUSwOfpGdk0k36XmNGea9jLss02fbyHf7KWcSzw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Pg-Spam-Score: -5.1 (-----)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

On Tue, Jan 10, 2017 at 07:22:17AM +0900, Michael Paquier wrote:
> On Tue, Jan 10, 2017 at 4:32 AM, Bruce Momjian <bruce@momjian.us> wrote:
> > On Sun, Jan  8, 2017 at 03:27:59PM +0900, Michael Paquier wrote:
> >> >> +        subdirectory of both the current directory and the
> >> >> +        <envar>PGDATA</envar> directory.
> >> >> This could say "of both the current directory and *then* the PGDATA
> >> >> directory" to outline the order of the actions taken by the check
> >> >> routine. Just my 2c on the matter.
> >> >
> >> > Ah, I see your point.  I ended up rewording the text to be more explicit
> >> > about the supplied argument and "searching".  Updated patch attached.
> >>
> >> -        Directory in which to find log segment files.  The default is to search
> >> -        for them in the <literal>pg_wal</literal> subdirectory of the current
> >> -        directory.
> >> +        Specifies a directory in which to find log segment files.
> >> +        In addition, searches are performed in the current directory,
> >> +        and the <literal>pg_wal</literal> subdirectory of both the current
> >> +        directory and the <envar>PGDATA</envar> directory.
> >> Hm. This still misses the point that the lookup at PGDATA is done only
> >> if no directory is defined. What do you think about the patch attached
> >> that lists the five possible patterns: 2 for the case where a
> >> directory is defined, and 3 for the default case.
> >
> > Understood.  Here is an updated patch which incorporates your
> > suggestions.
> 
> Thanks. This looks good to me.

Slightly modified version applied and backpatched to 9.6 (use pg_xlog). 
Thanks for your help.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs