pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
output_mode should be output_type 2+ messages / 2 participants [nested] [flat]
* output_mode should be output_type @ 2017-02-15 07:21 t.katsumata1122@gmail.com 0 siblings, 1 reply; 2+ messages in thread From: t.katsumata1122@gmail.com @ 2017-02-15 07:21 UTC (permalink / raw) To: pgsql-docs The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html Description: Hello. I found documentation bug. [47.6.3. Output Modes] https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html#LOGICALDECODING-OUTPUT... According to this document, "output_mode" parameter is used for changing output mode. But test_decoding uses "output_type" like below. --- test_decoding.c --- 155 opt->output_type = OUTPUT_PLUGIN_BINARY_OUTPUT; ----------------------- Sorry for trivial comment, but please fix this! -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: output_mode should be output_type @ 2017-02-15 22:22 Tom Lane <tgl@sss.pgh.pa.us> parent: t.katsumata1122@gmail.com 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2017-02-15 22:22 UTC (permalink / raw) To: t.katsumata1122@gmail.com; +Cc: pgsql-docs t.katsumata1122@gmail.com writes: > I found documentation bug. > [47.6.3. Output Modes] > https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html#LOGICALDECODING-OUTPUT... > According to this document, "output_mode" parameter is used for changing > output mode. But test_decoding uses "output_type" like below. Yup, you're right. Surprising that nobody noticed this before ... thanks for reporting it! regards, tom lane -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2017-02-15 22:22 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2017-02-15 07:21 output_mode should be output_type t.katsumata1122@gmail.com 2017-02-15 22:22 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox