Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-docs-owner+M9186=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
	id 1cxyRG-0006BI-QT
	for pgsql-docs@arkaria.postgresql.org; Tue, 11 Apr 2017 16:14:42 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-docs-owner+M9186=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
	id 1cxyRG-0004F2-Dn
	for pgsql-docs@arkaria.postgresql.org; Tue, 11 Apr 2017 16:14:42 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1cxyRF-0004EQ-OG
	for pgsql-docs@postgresql.org; Tue, 11 Apr 2017 16:14:41 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1cxyRC-00067b-SN
	for pgsql-docs@postgresql.org; Tue, 11 Apr 2017 16:14:40 +0000
Received: from bruce by momjian.us with local (Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1cxyRB-0002pr-PY; Tue, 11 Apr 2017 12:14:37 -0400
Date: Tue, 11 Apr 2017 12:14:37 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: marek.cvoren@gmail.com, pgsql-docs@postgresql.org
Subject: Re: Misleading
Message-ID: <20170411161437.GE4667@momjian.us>
References: <20170328110253.2695.62609@wrigleys.postgresql.org>
 <cd5ff30e-d97c-126b-4e22-939e5ae85d74@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="FCuugMFkClbJLl1L"
Content-Disposition: inline
In-Reply-To: <cd5ff30e-d97c-126b-4e22-939e5ae85d74@2ndquadrant.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org


--FCuugMFkClbJLl1L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr  5, 2017 at 12:28:46AM -0400, Peter Eisentraut wrote:
> On 3/28/17 07:02, marek.cvoren@gmail.com wrote:
> > My suggestion:
> >  - completely omit confusing default word:
> > `You can also specify user and port values, and whether you want the data
> > linked instead of copied.`
> 
> It's debatable whether that sentence is unclear, I think, but the change
> you propose actually loses the information about what mode is the
> default, which wouldn't be good.

I have applied the attached doc patch to clarify this.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

--FCuugMFkClbJLl1L
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pg_upgrade.diff"

diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
new file mode 100644
index 49aaf51..bf58a0a
*** a/doc/src/sgml/ref/pgupgrade.sgml
--- b/doc/src/sgml/ref/pgupgrade.sgml
*************** NET STOP postgresql-9.0
*** 336,343 ****
       Always run the <application>pg_upgrade</> binary of the new server, not the old one.
       <application>pg_upgrade</> requires the specification of the old and new cluster's
       data and executable (<filename>bin</>) directories. You can also specify
!      user and port values, and whether you want the data linked instead of
!      copied (the default).
      </para>
  
      <para>
--- 336,343 ----
       Always run the <application>pg_upgrade</> binary of the new server, not the old one.
       <application>pg_upgrade</> requires the specification of the old and new cluster's
       data and executable (<filename>bin</>) directories. You can also specify
!      user and port values, and whether you want the data files linked
!      instead of the default copy behavior.
      </para>
  
      <para>

--FCuugMFkClbJLl1L
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--FCuugMFkClbJLl1L--