pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedA typo
6+ messages / 5 participants
[nested] [flat]
* A typo
@ 2017-10-04 07:09 exclusion@gmail.com
0 siblings, 0 replies; 6+ messages in thread
From: exclusion@gmail.com @ 2017-10-04 07:09 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/0.0/static/collation.html
Description:
There is a word 'closet' in the notes on the page.
Shouldn't it be 'closest'?
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* A typo?
@ 2024-04-07 02:36 PG Doc comments form <noreply@postgresql.org>
2024-04-07 14:10 ` Re: A typo? David G. Johnston <david.g.johnston@gmail.com>
2024-04-07 14:24 ` Re: A typo? jian he <jian.universality@gmail.com>
0 siblings, 2 replies; 6+ messages in thread
From: PG Doc comments form @ 2024-04-07 02:36 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: kcai@wyebot.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/plpgsql-declarations.html
Description:
Under 43.3.1, "Notice that we omitted RETURNS real — we could have included
it, but it would be redundant."
Should that be "RETURNS tax" instead of "RETURNS real"?
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: A typo?
2024-04-07 02:36 A typo? PG Doc comments form <noreply@postgresql.org>
@ 2024-04-07 14:10 ` David G. Johnston <david.g.johnston@gmail.com>
2024-04-07 15:02 ` Re: A typo? Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 6+ messages in thread
From: David G. Johnston @ 2024-04-07 14:10 UTC (permalink / raw)
To: kcai@wyebot.com <kcai@wyebot.com>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Saturday, April 6, 2024, PG Doc comments form <noreply@postgresql.org>
wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/plpgsql-declarations.html
> Description:
>
> Under 43.3.1, "Notice that we omitted RETURNS real — we could have included
> it, but it would be redundant."
> Should that be "RETURNS tax" instead of "RETURNS real"?
>
The docs are correct.
David J.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: A typo?
2024-04-07 02:36 A typo? PG Doc comments form <noreply@postgresql.org>
2024-04-07 14:10 ` Re: A typo? David G. Johnston <david.g.johnston@gmail.com>
@ 2024-04-07 15:02 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2024-04-07 15:02 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: kcai@wyebot.com <kcai@wyebot.com>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Saturday, April 6, 2024, PG Doc comments form <noreply@postgresql.org>
> wrote:
>> Under 43.3.1, "Notice that we omitted RETURNS real — we could have included
>> it, but it would be redundant."
>> Should that be "RETURNS tax" instead of "RETURNS real"?
> The docs are correct.
Specifically, that bit is a declaration of the data type of the
function's result, not a specification of how to compute it.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: A typo?
2024-04-07 02:36 A typo? PG Doc comments form <noreply@postgresql.org>
@ 2024-04-07 14:24 ` jian he <jian.universality@gmail.com>
2024-04-07 15:11 ` Re: A typo? David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 6+ messages in thread
From: jian he @ 2024-04-07 14:24 UTC (permalink / raw)
To: kcai@wyebot.com; pgsql-docs@lists.postgresql.org
On Sun, Apr 7, 2024 at 6:30 PM PG Doc comments form
<noreply@postgresql.org> wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/plpgsql-declarations.html
> Description:
>
> Under 43.3.1, "Notice that we omitted RETURNS real — we could have included
> it, but it would be redundant."
> Should that be "RETURNS tax" instead of "RETURNS real"?
I think it's related to the plpgsql "RETURNS" and "RETURN" confusion.
RETURN can appear between "begin", "end".
RETURNS need to specify before "AS".
not omit "RETURNS real" would be:
CREATE FUNCTION sales_tax(subtotal real, OUT tax real) returns real AS $$
BEGIN
tax := subtotal * 0.06;
END;
$$ LANGUAGE plpgsql;
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: A typo?
2024-04-07 02:36 A typo? PG Doc comments form <noreply@postgresql.org>
2024-04-07 14:24 ` Re: A typo? jian he <jian.universality@gmail.com>
@ 2024-04-07 15:11 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 6+ messages in thread
From: David G. Johnston @ 2024-04-07 15:11 UTC (permalink / raw)
To: jian he <jian.universality@gmail.com>; +Cc: kcai@wyebot.com; pgsql-docs@lists.postgresql.org
On Sun, Apr 7, 2024 at 7:24 AM jian he <jian.universality@gmail.com> wrote:
> On Sun, Apr 7, 2024 at 6:30 PM PG Doc comments form
> <noreply@postgresql.org> wrote:
> >
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/16/plpgsql-declarations.html
> > Description:
> >
> > Under 43.3.1, "Notice that we omitted RETURNS real — we could have
> included
> > it, but it would be redundant."
> > Should that be "RETURNS tax" instead of "RETURNS real"?
>
> I think it's related to the plpgsql "RETURNS" and "RETURN" confusion.
> RETURN can appear between "begin", "end".
> RETURNS need to specify before "AS".
>
>
Right, the OP needs to have consulted the CREATE FUNCTION reference page to
find the definition of the RETURNS clause since it is language agnostic.
https://www.postgresql.org/docs/current/sql-createfunction.html
David J.
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-04-07 15:11 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 07:09 A typo exclusion@gmail.com
2024-04-07 02:36 A typo? PG Doc comments form <noreply@postgresql.org>
2024-04-07 14:10 ` Re: A typo? David G. Johnston <david.g.johnston@gmail.com>
2024-04-07 15:02 ` Re: A typo? Tom Lane <tgl@sss.pgh.pa.us>
2024-04-07 14:24 ` Re: A typo? jian he <jian.universality@gmail.com>
2024-04-07 15:11 ` Re: A typo? David G. Johnston <david.g.johnston@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox