pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedINSERT documentation
2+ messages / 2 participants
[nested] [flat]
* INSERT documentation
@ 2017-10-11 15:34 nat@makarevitch.org
2017-10-12 12:54 ` Re: INSERT documentation Marko Tiikkaja <marko@joh.to>
0 siblings, 1 reply; 2+ messages in thread
From: nat@makarevitch.org @ 2017-10-11 15:34 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/sql-insert.html
Description:
Hi,
In the "ON CONFLICT Clause" section of the official INSERT documentation (
https://www.postgresql.org/docs/10/static/sql-insert.html#sql-on-conflict )
you can read:
"index_column_name
The name of a table_name column."
This seems misleading to me as multiple columns may be named there. The
second sentence of this section's second paragraph is clear ("When
performing inference, it consists of one or more index_column_name") but a
reader jumping to the detail may miss this information.
Suggestion: s/The name of a table_name column/The name of at least one
column/
Thank you for the useful and appreciated work on PostgreSQL.
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: INSERT documentation
2017-10-11 15:34 INSERT documentation nat@makarevitch.org
@ 2017-10-12 12:54 ` Marko Tiikkaja <marko@joh.to>
0 siblings, 0 replies; 2+ messages in thread
From: Marko Tiikkaja @ 2017-10-12 12:54 UTC (permalink / raw)
To: nat@makarevitch.org; +Cc: pgsql-docs
On Wed, Oct 11, 2017 at 5:34 PM, <nat@makarevitch.org> wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/10/static/sql-insert.html
> Description:
>
> Hi,
>
> In the "ON CONFLICT Clause" section of the official INSERT
> documentation (
> https://www.postgresql.org/docs/10/static/sql-insert.html#sql-on-conflict
> )
> you can read:
> "index_column_name
> The name of a table_name column."
> This seems misleading to me as multiple columns may be named there. The
> second sentence of this section's second paragraph is clear ("When
> performing inference, it consists of one or more index_column_name")
> but a
> reader jumping to the detail may miss this information.
>
> Suggestion: s/The name of a table_name column/The name of at least one
> column/
>
But index_column_name *is*the name of only a single column. The syntax is
(irrelevant parts omitted):
( index_column_name [, ...] )
which means "opening parenthesis, index_column_name followed by zero or
more index_column_name, and a closing parenthesis". The documentation
seems correct to me.
.m
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2017-10-12 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 15:34 INSERT documentation nat@makarevitch.org
2017-10-12 12:54 ` Marko Tiikkaja <marko@joh.to>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox