public inbox for [email protected]  

help / color / mirror / Atom feed

From: Stephen Frost <[email protected]>
To: Michael Paquier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Missing column_constraint explanation
Date: Sat, 13 Jan 2018 21:06:22 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAB7nPqTagNTV5LbKz3Jekrd2DkxoaER+7sPKPSmjkd-aY1foeQ@mail.gmail.com>
References: <[email protected]>
	<CAB7nPqRgrAuqT-xeEZqtmaT7SToKQrE3Vd+yxigd0xtiy88x9Q@mail.gmail.com>
	<[email protected]>
	<CAB7nPqTagNTV5LbKz3Jekrd2DkxoaER+7sPKPSmjkd-aY1foeQ@mail.gmail.com>

Michael,

* Michael Paquier ([email protected]) wrote:
> On Thu, Dec 21, 2017 at 12:15 PM, Stephen Frost <[email protected]> wrote:
> > Now, if we could do that in such a way that we avoid having to actually
> > duplicate the 'source' for these productions into different places in
> > the documentation, that would be fantastic because it certainly isn't
> > fun having to find all the places that need to be updated, but I'm not
> > sure how easy that would be to do (and to make work with how psql's help
> > is generated...).
> 
> You are looking for something like how feature-supported.sgml is
> handled after its automatic generation, except that in this case you
> just create a new sgml file which has the definition data you want to
> load, define it with <!ENTITY blah SYSTEM "blah.sgml">, and then load
> it using something like an entity &blah; in the CREATE or ALTER TABLE
> docs. That's a bit of refactoring though, but you could shape it by
> putting all those lower-level definitions in a subdirectory like
> sgml/defs or such, avoiding any duplication in those definitions.

I'm not really sure that we want to go there for this case though.
Perhaps others disagree, but that seems like a lot to avoid this
particular duplication, which really isn't all that bad.

This patch also seems to have gotten lost in the shuffle of things, but
it still applies cleanly and I took another look at it today and it
looks good to me, so I'm going to stick it in the CF and mark it as
Needs Review for now.  Perhaps someone else can give it another
once-over to make sure everything looks good and, if so, mark it as
Ready for Committer and then I'll take care of it.

Thanks!

Stephen


Attachments:

  [application/pgp-signature] signature.asc (819B, 2-signature.asc)
  download

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Missing column_constraint explanation
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox