Date: Sun, 14 Jan 2018 17:00:01 +0900
From: Michael Paquier <michael.paquier@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: lampacz@gmail.com, pgsql-docs@postgresql.org
Subject: Re: Missing column_constraint explanation
Message-ID: <20180114080001.GA1045@paquier.xyz>
References: <20171220090816.25744.72592@wrigleys.postgresql.org>
 <CAB7nPqRgrAuqT-xeEZqtmaT7SToKQrE3Vd+yxigd0xtiy88x9Q@mail.gmail.com>
 <20171221031511.GX4628@tamriel.snowman.net>
 <CAB7nPqTagNTV5LbKz3Jekrd2DkxoaER+7sPKPSmjkd-aY1foeQ@mail.gmail.com>
 <20180114020622.GO2416@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI"
Content-Disposition: inline
In-Reply-To: <20180114020622.GO2416@tamriel.snowman.net>
Precedence: bulk


--oyUTqETQ0mS9luUI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 13, 2018 at 09:06:22PM -0500, Stephen Frost wrote:
> I'm not really sure that we want to go there for this case though.
> Perhaps others disagree, but that seems like a lot to avoid this
> particular duplication, which really isn't all that bad.
>=20
> This patch also seems to have gotten lost in the shuffle of things, but
> it still applies cleanly and I took another look at it today and it
> looks good to me, so I'm going to stick it in the CF and mark it as
> Needs Review for now.  Perhaps someone else can give it another
> once-over to make sure everything looks good and, if so, mark it as
> Ready for Committer and then I'll take care of it.

I may be missing something, but no patch is attached to this
thread. Honestly I think that duplicating this code should be avoided,
and the patch to produce is not that complicated technically. So are you
planning to just duplicate hte definitions in CREATE TABLE to ALTER
TABLE? This is a recipy for forgetting updates in the future on one
page or the other...
--
Michael

--oyUTqETQ0mS9luUI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlpbDgEACgkQnvQgOdby
QH0MJhAAgmyR5XzPBrUKHE8vUdRAKBtv7G+Dk5wdfRaNW3+I84OQzQeQVnysfNjh
IX8wiFxm/mFUax7G0dB0DA3k/0gKDtihuxex3/VSrd1UnNogG+nMb/PN8+k9xwsA
QJeNANuRh+0SsNUkKDRWZCLoxfivD1RSOPGYdjvKEELR9CreBN+bUiACsx/zFZVh
gUvjALGjrfDB2AhdjU5vrU7p9nmaB3NKp5fleycvrUO8G2k0bmBUquH/6pNi24v6
oGklvP0ZfW4MbEsNd+S+SBmNqCmXtNxm3cryT6bjxc5jDPn1/dw/gMerqztb8CNP
RJ4iI0QcFrJjvrEIJ56xM6NqmtHH0W4EvEOp3idkVfNCk14iYm/nv8TaLVbCC8m5
MV9m2q3ta0P88KGUE9yFtZwPgeYxEf6kktcKwEfv93s7AOUlKUhMucy47nv/vkgi
tdSMd8FRtvFfVl9klJj3FDw1FpS8xLdt+1oCnKrR4oskx4KY/Q9Non4ZX7nqhCjC
G0pv6SKFhK2lVJz+ZCq7AOJuPMxkXaUbbcuM496JS6OO2IzDUtcFD4dHlkTr2coP
X+02sxzcWysOfch9u4iRIo3AnWWijafxQHITNNpoiCYTq4SmKN9zDFhwWy+Mtez3
EWiWTyuT0DLOXk+AYYsxTLJRYR96vXCaBJBKdDYsoUKeG5QlyOg=
=o+Ph
-----END PGP SIGNATURE-----

--oyUTqETQ0mS9luUI--