Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1eeBBO-0001Vv-1I
	for pgsql-docs@arkaria.postgresql.org; Wed, 24 Jan 2018 02:53:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1eeBBN-0006Ow-DH
	for pgsql-docs@arkaria.postgresql.org; Wed, 24 Jan 2018 02:53:01 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1eeBBN-0006Om-4K
	for pgsql-docs@lists.postgresql.org; Wed, 24 Jan 2018 02:53:01 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <bruce@momjian.us>)
	id 1eeBBJ-0005yh-ND
	for pgsql-docs@postgresql.org; Wed, 24 Jan 2018 02:52:59 +0000
Received: from bruce by momjian.us with local (Exim 4.84_2)
	(envelope-from <bruce@momjian.us>)
	id 1eeBBI-0005DI-27; Tue, 23 Jan 2018 21:52:56 -0500
Date: Tue, 23 Jan 2018 21:52:56 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-docs <pgsql-docs@postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: PARALLEL in old syntax for CREATE AGGREGATE
Message-ID: <20180124025256.GC17109@momjian.us>
References: <8400AFAE-4625-4F58-9A7A-0EF8BF2C9189@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8400AFAE-4625-4F58-9A7A-0EF8BF2C9189@yesql.se>
User-Agent: Mutt/1.5.23 (2014-03-12)
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk


Robert, can you review the attached patch since it references your
commit?  Thanks.

---------------------------------------------------------------------------

On Mon, Nov 27, 2017 at 04:00:42PM +0100, Daniel Gustafsson wrote:
> When looking at review comments on one of my patches, I noticed that commit
> 41ea0c23761 didn’t include the PARALLEL keyword for the old style CREATE
> AGGREGATE syntax.  Since it is supported, and commit 59b71c6fe6c use it in a
> testcase, it seems reasonable to add something along the lines of the attached
> patch to the docs.
> 
> cheers ./daniel
> 

> From 2ed82ee3f3fa28bd69f2981730cf60d89c8f3867 Mon Sep 17 00:00:00 2001
> From: Daniel Gustafsson <daniel@yesql.se>
> Date: Mon, 27 Nov 2017 15:29:15 +0100
> Subject: [PATCH 2/2] doc: add PARALLEL option to old syntax for CREATE
>  AGGREGATE
> 
> The old pre-8.2 syntax for CREATE AGGREGATE also support PARALLEL,
> even though it's required to be quoted as PARALLEL is an unreserved
> keyword.
> ---
>  doc/src/sgml/ref/create_aggregate.sgml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/src/sgml/ref/create_aggregate.sgml b/doc/src/sgml/ref/create_aggregate.sgml
> index a4aaae876e..d813ec41e6 100644
> --- a/doc/src/sgml/ref/create_aggregate.sgml
> +++ b/doc/src/sgml/ref/create_aggregate.sgml
> @@ -80,6 +80,7 @@ CREATE AGGREGATE <replaceable class="parameter">name</replaceable> (
>      [ , MFINALFUNC_MODIFY = { READ_ONLY | SHARABLE | READ_WRITE } ]
>      [ , MINITCOND = <replaceable class="parameter">minitial_condition</replaceable> ]
>      [ , SORTOP = <replaceable class="parameter">sort_operator</replaceable> ]
> +    [ , "PARALLEL" = { SAFE | RESTRICTED | UNSAFE } ]
>  )
>  </synopsis>
>   </refsynopsisdiv>
> @@ -630,6 +631,10 @@ SELECT col FROM tab ORDER BY col USING sortop LIMIT 1;
>        functions are not consulted by the planner, only the marking of the
>        aggregate itself.
>       </para>
> +     <para>
> +       Note that when using the old syntax, <literal>"PARALLEL"</literal> must
> +       be quoted.
> +     </para>
>      </listitem>
>     </varlistentry>
>  
> -- 
> 2.14.1.145.gb3622a4ee
> 

> 
> 


-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +