Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1wr3-000899-HG for pgsql-docs@arkaria.postgresql.org; Fri, 30 Mar 2018 16:26:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1wr1-0000en-N6 for pgsql-docs@arkaria.postgresql.org; Fri, 30 Mar 2018 16:26:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1wr1-0000ee-HE for pgsql-docs@lists.postgresql.org; Fri, 30 Mar 2018 16:26:15 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1wqu-0002rj-2R for pgsql-docs@lists.postgresql.org; Fri, 30 Mar 2018 16:26:14 +0000 Received: from bruce by momjian.us with local (Exim 4.84_2) (envelope-from ) id 1f1wqq-0005x0-2M; Fri, 30 Mar 2018 12:26:04 -0400 Date: Fri, 30 Mar 2018 12:26:04 -0400 From: Bruce Momjian To: Magnus Hagander Cc: Euler Taveira , scott.ure@caseware.com, pgsql-docs@lists.postgresql.org Subject: Re: Documentation for varbit is missing size parameter Message-ID: <20180330162604.GM8476@momjian.us> References: <152074343671.1853.18284519607571497106@wrigleys.postgresql.org> <20180330151828.GL8476@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Fri, Mar 30, 2018 at 05:39:46PM +0200, Magnus Hagander wrote: > On Fri, Mar 30, 2018 at 5:18 PM, Bruce Momjian wrote: > > On Fri, Mar 16, 2018 at 01:17:04AM -0300, Euler Taveira wrote: > > 2018-03-11 1:43 GMT-03:00 PG Doc comments form : > > > The documentation for the varbit data type is missing the size > parameter "[ > > > (n) ]". > > > > > Good catch! It seems to be an oversight in commit > > 768b647ead78d0d63915c1708cad13c2468f9440. The attached patch adds it. > > Wow, that commit is from 2004.  Patch applied and backpatched to v10. > > > If it goes all the way back to 2004, why not backpatch further? Uh, I am always debating how important it is to backpatck vs the churn we require of translations of our docs. In this case, it didn't seem worthwhile to have all of those translations try to deal with this change for all those back branches. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +