Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fWq16-0000cV-4M for pgsql-docs@arkaria.postgresql.org; Sat, 23 Jun 2018 21:24:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fWq14-0005r5-4e for pgsql-docs@arkaria.postgresql.org; Sat, 23 Jun 2018 21:24:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fWq13-0005qy-Rs for pgsql-docs@lists.postgresql.org; Sat, 23 Jun 2018 21:24:18 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fWq0w-0005Rb-KF for pgsql-docs@lists.postgresql.org; Sat, 23 Jun 2018 21:24:16 +0000 Received: from bruce by momjian.us with local (Exim 4.84_2) (envelope-from ) id 1fWq0u-0007R4-LX; Sat, 23 Jun 2018 17:24:08 -0400 Date: Sat, 23 Jun 2018 17:24:08 -0400 From: Bruce Momjian To: Brad DeJong Cc: Euler Taveira , pgsql-docs@lists.postgresql.org Subject: Re: postgresql 11 release notes Message-ID: <20180623212408.GD2830@momjian.us> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Thu, Jun 21, 2018 at 05:08:39AM -0500, Brad DeJong wrote: > On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira wrote: > > I left this change in the v2 patch. > > I didn't remove it because it was an Oxford comma; I removed it because > > there are only two items, tables and files, so this should not be a comma > > separated list. > > Unlogged and temporary both modify tables and tell us what kind of tables > > are being excluded. > > If this was a list, the items should be semi-colon separated because of > the > > comma between unlogged and temporary. > > For example - Exclude unlogged, temporary tables; b-tree indexes; and > > pg_internal.init files from streaming base backups. > > > I see. I think the sentence should be "Exclude unlogged tables, > temporary tables, and pg_internal.init files from > streaming base backups". > > > I like it. Done.  Patch applied. This was a great help, thanks. The "This features" typo was already found. I did not apply this part since it would have added whitespace after the period. > - Add - linkend="pg-stat-activity-view">pg_stat_activity.backend_type > + pg_stat_activity. > + backend_type -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +