Date: Thu, 23 Aug 2018 16:58:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres docs <pgsql-docs@postgresql.org>
Subject: "System roles" mentioned in psql documentation
Message-ID: <20180823075800.GA30782@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Fba/0zbH8Xs+Fj9o"
Content-Disposition: inline
Precedence: bulk


--Fba/0zbH8Xs+Fj9o
Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw"
Content-Disposition: inline


--wac7ysb48OaltWcw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

I have noticed that psql documentation mentions "system roles", however
in all other parts of the docs, we use the term "default roles".
Shouldn't we make this term more consistent and also add a link to the
table describing those roles?  Please see the attached.

Thanks,
--
Michael

--wac7ysb48OaltWcw
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="psql-system-roles.patch"

diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index eb9d93a168..df762b811c 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1521,7 +1521,8 @@ testdb=&gt;
         unified into <quote>roles</quote>, this command is now equivalent to
         <literal>\du</literal>.)
         By default, only user-created roles are shown; supply the
-        <literal>S</literal> modifier to include system roles.
+        <literal>S</literal> modifier to include default roles described in
+        <xref linkend="default-roles-table"/>.
         If <replaceable class="parameter">pattern</replaceable> is specified,
         only those roles whose names match the pattern are listed.
         If the form <literal>\dg+</literal> is used, additional information
@@ -1711,7 +1712,8 @@ testdb=&gt;
         unified into <quote>roles</quote>, this command is now equivalent to
         <literal>\dg</literal>.)
         By default, only user-created roles are shown; supply the
-        <literal>S</literal> modifier to include system roles.
+        <literal>S</literal> modifier to include default roles described
+        in <xref linkend="default-roles-table"/>.
         If <replaceable class="parameter">pattern</replaceable> is specified,
         only those roles whose names match the pattern are listed.
         If the form <literal>\du+</literal> is used, additional information

--wac7ysb48OaltWcw--

--Fba/0zbH8Xs+Fj9o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlt+aQgACgkQnvQgOdby
QH0bvA//VuZKnMOPkHbV+oT5CGs+LaoBj8ukaF72IwrC9BooSOOIyTEb+jSTSHh1
Q9Z2CyA0kDyX26zZCdv7zOG+QpsUZlCmUuwdkB7rTqttWTxNTidODJPepRwaSpic
FNFFEB5amqYN3biaxMmoT2y/b5B8OanSvnrqwRTBkUmPGsqlZhpzZPQJjMXje/WC
PLuOPYQDRK4vUcLxi3Rn9gIU1fUEM5ACHhPpjZLBxvlLZoyfHpTEl3n3RrwGRlN6
Y05+alUhIAVZQ35kwveoGaIohV2eovQLsY3j/m31kGFcfJjpCcbSTziDy5mvmBm5
yWKfNPa6ioYHNZrFOFIm46hSjavVowGwo2qMkjCyzoQ2rBTXT2Mos04ktxbVbV+i
jGHKWe6wgQQNhi/4Wi39pVlWQJXunoyWQt36YcnkEG9DgYr/E85rQiiRgIjbYBLS
Tndu5F5MlDXUt3kpJiwZ0Fd1l3ta2Xp5TN+lBwvknjp29ssteXJ1yQ0Mf4gytq6L
gTXbeeoYMrGthQXbXn2Ed6OnVuqmBllswrAD7SJknJXGXM1SwQKwGlmpc6le858H
usroSQvf2ffPSzTZnyB7RLwVBilCRGGpRJUTE18+SCTec6iwQAcbyFbOsjWsE+Uk
DzLJkZ0asAkQX3g1mdAj14IBgkIj2LXyucsPJo5uYjsVRRBxHnU=
=nGOb
-----END PGP SIGNATURE-----

--Fba/0zbH8Xs+Fj9o--