Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ftggz-0000za-63 for pgsql-docs@arkaria.postgresql.org; Sat, 25 Aug 2018 22:06:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ftggw-0002Ve-Td for pgsql-docs@arkaria.postgresql.org; Sat, 25 Aug 2018 22:05:58 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ftggw-0002VS-K2 for pgsql-docs@lists.postgresql.org; Sat, 25 Aug 2018 22:05:58 +0000 Received: from sraihb2.sra.co.jp ([202.32.10.6]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ftggs-00079I-Go for pgsql-docs@postgresql.org; Sat, 25 Aug 2018 22:05:56 +0000 Received: from srascf.sra.co.jp (srascf [133.137.8.80]) by sraihb2.sra.co.jp (Postfix) with ESMTP id 69B572A1620 for ; Sun, 26 Aug 2018 07:05:52 +0900 (JST) Received: from srascb.sra.co.jp (unknown [133.137.8.65]) by srascf.sra.co.jp with smtp id 5662_00c9_604ec7b2_a668_47c2_8901_3bf252af404c; Sun, 26 Aug 2018 07:05:51 +0900 Received: from sranhm.sra.co.jp (osspc25 [133.137.174.97]) by srascb.sra.co.jp (Postfix) with ESMTP id 386122D6943 for ; Sun, 26 Aug 2018 07:05:52 +0900 (JST) Received: from localhost (sraihb-hub.sra.co.jp [133.137.8.6]) by sranhm.sra.co.jp (Postfix) with ESMTP id 01D0DA0F33; Sun, 26 Aug 2018 07:05:51 +0900 (JST) Date: Sun, 26 Aug 2018 07:05:51 +0900 (JST) Message-Id: <20180826.070551.1769438420290125254.t-ishii@sraoss.co.jp> To: bpd0018@gmail.com Cc: pgsql-docs@postgresql.org Subject: Re: Enhancing protocol.sgml From: Tatsuo Ishii In-Reply-To: References: <20180728.125153.1487613390757751788.t-ishii@sraoss.co.jp> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Bradley, Thank your for your follow up. Your patch looks good to me. Can you please re-send your message in pgsql-hackers attaching to this thread? https://www.postgresql.org/message-id/flat/20180730.080748.1152436144966943439.t-ishii@sraoss.co.jp I have registered the thread in CommitFest: https://commitfest.postgresql.org/19/1738/ Unfortunately CommitFest app does not allow to handle emails other than posted to pgsql-hackers. So I decided to post to pgsql-hackers after posting to pgsql-docs. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp From: "Bradley DeJong" Subject: Re: Enhancing protocol.sgml Date: Fri, 24 Aug 2018 15:43:28 +0000 Message-ID: > On 2018-07-27, Tatsuo Ishii wrote ... >> ... I think this should be mentioned in protocol.sgml as well. ... > > I agree. It is already mentioned as one of the differences between v2 > and v3 but an implementer should not need to read that section if they > are only implementing v3. (I know I've never looked at it before.) > > Using protocol.diff as a base, I changed the phrasing to be more > prescriptive for v3 protocol implementers (don't send a final line, be > prepared to receive a final line), changed passive voice to active > voice and fixed one COPYData -> CopyData capitalization. > > I also called this out in the description of the CopyData message > format because that is where the termination line would be > transmitted.