Date: Tue, 2 Oct 2018 16:41:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: chris+postgresql@qwirx.com, pgsql-docs@lists.postgresql.org
Subject: Re: pgrowlocks columns do not match docs: "modes" instead of
 "lock_type"
Message-ID: <20181002074152.GD17642@paquier.xyz>
References: <153838692816.2950.12001142346234155699@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+SfteS7bOf3dGlBC"
Content-Disposition: inline
In-Reply-To: <153838692816.2950.12001142346234155699@wrigleys.postgresql.org>
Precedence: bulk


--+SfteS7bOf3dGlBC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 01, 2018 at 09:42:08AM +0000, PG Doc comments form wrote:
> The description of the pgrowlocks extension says that the function return=
s a
> column called "lock_type". However this column is really called "modes", =
as
> shown in contrib/pgrowlocks/pgrowlocks--1.2.sql:
>=20
> CREATE FUNCTION pgrowlocks(IN relname text,
>     OUT locked_row TID,     -- row TID
>     OUT locker XID,     -- locking XID
>     OUT multi bool,     -- multi XID?
>     OUT xids xid[],     -- multi XIDs
>     OUT modes text[],       -- multi XID statuses
>     OUT pids INTEGER[])     -- locker's process id
> RETURNS SETOF record
> AS 'MODULE_PATHNAME', 'pgrowlocks'
> LANGUAGE C STRICT PARALLEL SAFE;

0ac5ad5 has updated pgrowlocks from 1.0 to 1.1 and it forgot the
documentation.  The order of the columns is correct, but the example was
not.  So I updated the documentation with a fresh one, and fixed it all
the way down to 9.3.  Thanks for the report, Chris!
--
Michael

--+SfteS7bOf3dGlBC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluzIUAACgkQnvQgOdby
QH3aGw//fL0fiiP9ORzd2n0VwAaCqKrukTTDIz1R4ayqJ4bOxAnpMAmnOD9Eo1zP
2qaFjMFVJu0CM2+3KwKs+Af4bfcyROhpOZnNyCqGOs8/f+TRjkj9zqkApxusA7Fd
CVAbl7JirTp8vn1Sxf2jjRoHcEFZ1JUZzf53/5DSmvUGafcEucbX/eCmwDMpr3PI
1jsHSikHMJgZQ3CJB95RiZzmzSBL1p3FNYAG1Stx+HCxrwwxOP5877MKs3WS9rJX
EAXKFrBirJES+fuOHECxRfJrINwMYwaCXunPdOIbXEl5DSHUKNRDz1UvpWY/gtl0
bBiiiEvf/zmqOzA8JN4+VIDGb22Jf7ZdvKvbryCgFQ86ifP+IocG1Pu9ghCdwh0w
r4nFWyk/cQn4cxXjNo0BzH9A8GwhtPE+oNiuMApg6RITFnmiM6cXKkOyGOu5uboe
gAA4oH/thPPNm5eAaRwzxT29tFNfk2pp72+9ul7gAgKFeTmdMNNrG8JhiKFqvr+h
yIYiAwHQz56jcmTFQ8Bk5gVqTiK2+YDIzYKb04l7kwUOTPu0TEhxB9qPPqPAfCuQ
YxJM6ZcyDglAcxS8k0Rh/aDSK82BywrH93/4hmdd1Bc2wiUK4zD4y2G62n5edYvM
kXUjJfXGlBDoHbPwaLQFi0EYR1WHG/ZiZoYBZXy00ONwbp7oUF4=
=sclI
-----END PGP SIGNATURE-----

--+SfteS7bOf3dGlBC--