Date: Tue, 6 Nov 2018 13:42:20 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Nikolay Samokhvalov <samokhvalov@gmail.com>,
	peter.eisentraut@2ndquadrant.com, nat@makarevitch.org,
	pgsql-docs@lists.postgresql.org
Subject: Re: effective_cache_size
Message-ID: <20181106184220.GA31546@momjian.us>
References: <20181105161231.GA13780@momjian.us>
 <20181105170112.dtxazkxcyuoszfi2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181105170112.dtxazkxcyuoszfi2@alvherre.pgsql>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Mon, Nov  5, 2018 at 02:01:12PM -0300, Alvaro Herrera wrote:
> On 2018-Nov-05, Bruce Momjian wrote:
> 
> > Well, here are the lines in guc.c:
> > 
> >             gettext_noop("Sets the planner's assumption about the size of the data cache."),
> >             gettext_noop("That is, the size of the cache used for PostgreSQL data files. "
> >                          "This is measured in disk pages, which are normally 8 kB each."),
> 
> I suggest "the size of data caches", plural, in the first line (two
> letters shorter, since I lost the article).  And in the second line, use
> "... the size of the combined caches used for Pg data files, including
> both the kernel cache and shared buffers" -- a few words longer, which
> seems worth it to me.

OK, I handled it slightly differently:

	https://git.postgresql.org/pg/commitdiff/b43df566b372650a9b9e2a0dd9e695c1f16da14f

I think "the size of" anything plural is confusing so I said "the total
size of".

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +