Date: Thu, 29 Nov 2018 11:23:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: splarv@ya.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Return codes for archive and restore commands
Message-ID: <20181129022347.GH626@paquier.xyz>
References: <154340283171.1324.10549444217937216132@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Rmm1Stw9KgbdL9/H"
Content-Disposition: inline
In-Reply-To: <154340283171.1324.10549444217937216132@wrigleys.postgresql.org>
Precedence: bulk


--Rmm1Stw9KgbdL9/H
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 28, 2018 at 11:00:31AM +0000, PG Doc comments form wrote:
> For the archive command:
> <=3D128 There are not errors in the PostgreSQL log (messages with severity
> equal or higher than ERROR). Firstly 3 messages of type LOG about fault,
> then WARNING about this and pause for 1 minute, then repeated.
> >=3D129 FATAL error in the PostgeSQL log. The message about stoping an ar=
chive
> process, but not the database. Repeated after roughly 16 seconds.

This code is around for some time, and comes from this commit:
commit: 3ad0728c817bf8abd2c76bd11d856967509b307c
author: Tom Lane <tgl@sss.pgh.pa.us>
date: Tue, 21 Nov 2006 20:59:53 +0000
committer: Tom Lane <tgl@sss.pgh.pa.us>
date: Tue, 21 Nov 2006 20:59:53 +0000
On systems that have setsid(2) (which should be just about everything except
Windows), arrange for each postmaster child process to be its own process
group leader, and deliver signals SIGINT, SIGTERM, SIGQUIT to the whole
process group not only the direct child process.  This provides saner behav=
ior
for archive and recovery scripts; in particular, it's possible to shut down=
 a
warm-standby recovery server using "pg_ctl stop -m immediate", since delive=
ry
of SIGQUIT to the startup subprocess will result in killing the waiting
recovery_command.  Also, this makes Query Cancel and statement_timeout apply
to scripts being run from backends via system().  (There is no support in t=
he
core backend for that, but it's widely done using untrusted PLs.)  Per gripe
=66rom Stephen Harris and subsequent discussion.

The relevant part if pgarch_archiveXlog() in pgarch.c, and this part
is most relevant:
* Per the Single Unix Spec, shells report exit status > 128 when a
* called command died on a signal.

> In this case PostgreSQL tries confirm rules for return codes of a unix
> shell. A unix shell return 126 in the case of "command not executable", 1=
27
> in the case "command not found", 128+# of signal in the case if applicati=
on
> interrupted by uncatched signal.

If you were to rewrite those paragraphs or make them more precise, how
would you actually shape your suggestions?  I personally quite like the
current formulations, but I am rather used to it to be honest.
--
Michael

--Rmm1Stw9KgbdL9/H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlv/TbMACgkQnvQgOdby
QH2NCQ//RjeuW8J6ok4Ng0jqoHYIg//qr8zpg2Y1dKzxrRKadCVr1JECMtx4U1Rp
MBdCqaJPxLkU0acNQN2SlKkIlA4Dd3uAj1JPo+hKNJ09WS8iGGS3VLJTD6cK5t5o
sNktwcZOEC5339qhreiW6J/mzYuZ3BDa9NapHTB4/oHJSr7M8IhwL99hxuwOAgLI
WwZPPdNHPfVB1KZaK35YOzKi8czrdpYusyKL5sFXWKqP8rx9w8MKo+mZT2dCmqe4
6ffQeX4snVvVxZKMJFtQ7VkN9AV5KICwTLLH7X7yyQzhQm8dTHFevTnCpXYueGlQ
flZ9+QM3bDXZH9l9BkslrCDYUqxS7q2uSqGU9wFP6loAGqnR9nt/Dx+tmb0M7Et0
856Wrr6FZvU5JriVqRbNoBUzkl0qVx1PqkeR8wtymVMhqZ+WogG9coWlGGTdlIOw
uO9OGx9jwtBnNldKSapEJUR1VmrC9vQjD2fDX3fqsmEmXq1MN5QJYiegyIUEJ4qa
lShNrtf6pAKNlLhhhEWNTlG9fE8MNK/Di9eDRG/MKILHa7Ekjl62TdDu9bOMWn92
HX5X6PSmqqwQWwdw5f0Q0NeyxGHvDryuCm4Vgnq2NRhCy1kz6t5VwJKRa3VKihqk
W3LeReTTauwjL63IKlSCjnXh8qWk2YIJv/q96Day9vmDgXAXIoc=
=EFZU
-----END PGP SIGNATURE-----

--Rmm1Stw9KgbdL9/H--