Date: Tue, 4 Dec 2018 09:18:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Maksim Milyutin <milyutinma@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of replay_lag attribute in
 pg_stat_replication view
Message-ID: <20181204001802.GK3423@paquier.xyz>
References: <27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VJJoKLVEFXdmHQwR"
Content-Disposition: inline
In-Reply-To: <27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com>
Precedence: bulk


--VJJoKLVEFXdmHQwR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote:
> I have noticed that in description of *flush_lag* in pg_stat_replication
> view (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
> there exists unknown value of synchronous_commit parameter - *remote_flush*.
> I think it was meant to use the value *on*.

Yes, you are right.  It should be "on" as "remote_flush" is not a valid
value.  remote_flush is listed in SyncCommitLevel though, so this makes
me wonder if we should also introduce a new value for this purpose
available for users.  The fix you propose looks good to me.  Any
opinions from others?
--
Michael

--VJJoKLVEFXdmHQwR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwFx7oACgkQnvQgOdby
QH09DxAAkK3mFrXvnYOGPSkQOP2MekGMPF0LAIHmuo2e3HGMycqUUQcYCtmWHlzO
GCjJ+gRRRFTizOx0iCOfUvA3vJ4S/KTggeqUIfoFBIHRfnMPnIoOAaYWZggI3Jiy
luwvko009w+LqFdsLDuB2hHv0rF+H9UoJKfmGXjsdiJtMRfNpSFP6NdHz3mZP3f9
OCWhBAUBhWevDVUVXprVZqx+A75tkg+yfT/Geea45mZTSOXs5p/bNSyax0uwC0Cs
lgra4CBXLxlQI63e7W/TbakhN6LfUit6GY5kHZID+KVuPvPQgWC/+v3wbem8RHmw
U2Dp0IbrsnpuWPfoInDMOxrrvPI7PDYf5k9Mq/F28inbEuCDU11Ngz0RbJ5fnizZ
87r3r1cL8VUWLRIuDw60i6dnQmFfxEDpYTkcJLX1jg9jZpboBWZY872dz2eMX8Ad
3lFzH2Blz8DqQdfFtU3QjHtT/6iNoHn5qBTOHiTdiS7o38UIKe+XzYhTGQ0/oe0I
FhwKM7IlLbfZcLaTHGY+IO9WA0QrnMvvPMhhTGne+OMGqjW5BsBzlVgOs69UN7M0
fVYLlVN8Wt6pO9ZsVTE+VT0mW9hmbwlUULETgjA1c6pK9ZJc+H71n1TXgW5Cf8ho
sVujJN9yuasE+OvFomapyNCLiV25gru6i/Tl5+TzKP53SZLiaCY=
=28B/
-----END PGP SIGNATURE-----

--VJJoKLVEFXdmHQwR--