Date: Tue, 4 Dec 2018 11:19:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: milyutinma@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of replay_lag attribute in
 pg_stat_replication view
Message-ID: <20181204021925.GM3423@paquier.xyz>
References: <27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com>
 <20181204001802.GK3423@paquier.xyz>
 <CAEepm=3rVm=krEhefk-o=e4KTG3ry_QMJWcn7DgFSGbOc4_UYQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="p1Od3smaOkJqivj4"
Content-Disposition: inline
In-Reply-To: 
 <CAEepm=3rVm=krEhefk-o=e4KTG3ry_QMJWcn7DgFSGbOc4_UYQ@mail.gmail.com>
Precedence: bulk


--p1Od3smaOkJqivj4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 04, 2018 at 01:28:15PM +1300, Thomas Munro wrote:
> On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier <michael@paquier.xyz> wrot=
e:
>> Yes, you are right.  It should be "on" as "remote_flush" is not a valid
>> value.  remote_flush is listed in SyncCommitLevel though, so this makes
>> me wonder if we should also introduce a new value for this purpose
>> available for users.  The fix you propose looks good to me.  Any
>> opinions from others?
>=20
> +1 for the patch.

Thanks for confirming, Thomas.  I'll go apply hopefully tomorrow if
nobody has objections.

> As for introducing remote_flush as the true name of the level, this
> was discussed but somehow went off-course and never made it to the
> finish line:
>=20
> https://www.postgresql.org/message-id/flat/CAEepm%3D3FFaanSS4sugG%2BApzq2=
tCVjEYCO2wOQBod2d7GWb%3DDvA%40mail.gmail.com

Oh, I forgot this one.  We may want to revive that...  remote_flush is
more meaningful than on, especially since there are more and more
possible values for synchronous_commit.
--
Michael

--p1Od3smaOkJqivj4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwF5C0ACgkQnvQgOdby
QH2OpA//chfGsUB9axAdEBnQg07yWIybiFrqtA556cLWFwmMMRaLapqPk29oG9nz
T+lwyzrltbnp1D5dpc/+GcbB0OJRjuOjFWAkdQaBB6PTTJjZLb753CC1x3VB5eb3
i/a1G970gXl34Zelx6jzgb65UQXR1ugxLvlGOeqlHkuhVQazcnbUT6Ki3goOeQ77
9QPAhAE8rkEfzm8Y6okameVXVOqwQYr1gKAgvyc9lPRaas5P2U5Ms9NFfSE/sQtj
7BbrfuVCNcJbb5/XdOqe6adS8DXSjFmOqziHflCogSmy+IMdI0PVoXDJv8JnYENy
Lac6SH9dh583nwWDTOPPz4yDGnpkGHfevdsh/4oqZzNwajSkpmOpa3sq7xjvI/kD
t197KrQ9YXj/KVhT6UEn852qZIKQOkaHKC2dhZR7j92Z6ZheD2BkVDxELtJnGRPn
tnl3aes/avzODjY9dpUefBGZWp2Il7lqEFwKwWICFowsISK2zsEYXbiuckybyZnl
HzEGkIpKs9igcdx1ONgPwormXnqFHVgUWDQvixTdoHb+Kj/t5ixvXuw+l9P+KYvz
EgriLhrRebrc4OwnH8Oeh5w8QMyrrICeTf+KDi1osU6Vqd1EUVwz7VZTUB9W966R
hjKBi419tMCZ1zy5VGLCizImjzVn0q4i/fXZoPm1no/0+xlHkWQ=
=c9u8
-----END PGP SIGNATURE-----

--p1Od3smaOkJqivj4--