Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1giTjn-0005i4-A9 for pgsql-docs@arkaria.postgresql.org; Sun, 13 Jan 2019 00:34:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1giTjk-0001qY-T2 for pgsql-docs@arkaria.postgresql.org; Sun, 13 Jan 2019 00:34:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1giTjj-0001qR-4K for pgsql-docs@lists.postgresql.org; Sun, 13 Jan 2019 00:34:48 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1giTje-0008G4-S5 for pgsql-docs@postgresql.org; Sun, 13 Jan 2019 00:34:46 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EB819225AE; Sat, 12 Jan 2019 19:34:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 12 Jan 2019 19:34:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=cjZjvEAPsgAB52+g6oFr+idnvF3 Rz3vk0cNhGB9nUag=; b=c4IYPEiz08sP30FjqFQ8l85pxiSgoXIbCp8esfKik90 GCPinKyK7jcpsRP+9iGSQ828qcdBwuazw1BJmGX30MkNXViBfzplea1xIohhnV2d Es8I2fkOj758L5KmCLW4Zx5K494UtgV2DaogGbSIgdv0LyAwQ8nBWSio5nBy6uzv zf+zjhKQ5gpO1vWoPJMPLcxwShX0vHoKLeL1Ne9P8v0tawxMAxSe/fjHiIlPchz9 JP4EchJaBEC1wuy+2kL83+28sZy8ynP1E0uT/l0AnA6jVVyuxP6gYIgJtwbnW4po iPUQNYwiHn8T9spp3cQ6Tx4iMaaTNDVvYaIgK3/PlXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cjZjvE APsgAB52+g6oFr+idnvF3Rz3vk0cNhGB9nUag=; b=t8DdCVfGU2zJL29IQBAjdD DXJlnk3kfwvME2q/2QufugGk/YB60fm21xhtFkVtny768EllnxAJMyajZ9kSb6ew o0+ByErn4outKSkVjHPDpCI3R1qESlZ+KCb3NDoMfrbhPK9EvzCn73zUiyJOYxvJ o9f26pqKxp/ode/fqonqaHEBeA7t/lXdjQeqQd5X9o67ZsQQmWGwZhGiQxsQQxBn A+9kNnYCLKBmQo8b+kUWTC9V+26EqhpfqFsmWEO7qZWE7qN7FASp+mpA6vx3PdbH /7fsUkWzFeOnCZN/bSgSeDcTze8EsAIUqSTqMP7bTIgXQbkHHaiwmAWTseFWX0Dg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfeejgddukeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtd erredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggv lhesphgrqhhuihgvrhdrgiihiieqnecukfhppeeiuddrvdduhedrudefjedrudeivdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiien ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B12C100BB; Sat, 12 Jan 2019 19:34:38 -0500 (EST) Date: Sun, 13 Jan 2019 09:34:36 +0900 From: Michael Paquier To: Alexander Lakhin Cc: "pgsql-docs@postgresql.org" Subject: Re: Some typos in documentation Message-ID: <20190113003435.GA32588@paquier.xyz> References: <9b5a3a85-899a-ae62-dbab-1e7943aa5ab1@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <9b5a3a85-899a-ae62-dbab-1e7943aa5ab1@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 13, 2019 at 12:17:07AM +0300, Alexander Lakhin wrote: > While cross-checking the unique words in doc/ I found a few typos. Those are good finds, thanks for the report! > LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in > pgstat.c) or LockFileCreateWRITE in pg.stat.s should use CamelCase in > whole. I don't find any dependencies so I would prefer the latter. For consistency with the rest I think that we should use LockFileCreateWrite in pgstat.c as well as you do, though this could be qualified as a behavior change. That's also the grammar which is documented since the beginning. Any objections from others? > All the corresponding patches are attached. Cool, I'll see to apply them where needed. I'll just wait to see if anybody has comments about the pgstat.c portion. -- Michael --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlw6h5sACgkQnvQgOdby QH1TNQ//d+fAx5B1x/PCrnxRIvfSirua1Vre1/Gccb5ioPk+0yyEM0Pv4kaEmx9j lDuYOcxinEEBxMQL9644lN9S7dI8de0OUFD8s9WNx4bFUblT7RzqUUu+cnY6YZ5E JGkJAjY+btHVLBCxW/ByJoq5UlD/miRKzYUQwhtan4+0OcVJfxTHdgwR9Ve82dJY yAdSBljh9enulP0rfa0jrVBojfaSbC94Amt9ip+5VtlR+plNb3g1hW8jwhymR5rA 2jPMVyhB65KAKn5I0kz3toD175ChBrswkTXPp0dFnBkeuDXX3XQz2DW9+8L6TSqH kjxJ/yXjoQm4Zo4QnhTvZyQqpfiFFCf+dKe2z6V6n8omoi8qhy7J9cnbau2uL+pj /P4zJd4ZxJidykRBB8gjrvCnABSn7qnU/BHtwsLdNPGd/8yUBRBrT5lGS5jKmzPP 1xwBDWi7xw6YZS3BLVc37zfcfdTv5LC+0CtVt5tbMA6Er93nkOCKUjbuXE/WtlaM u3cfNBLK+/c9tZGW5Q4q/9IurZFwqK0/ODS7VffgmqBaIPTDC8+yiSCTb0rZca5F XOo+wabctIqRLEzPF/sCuzFuv6F/no5ag/UGLw2Pw/l7jWUyLJqB7b5w4EgILfdk fwR+Gk8c/Kgu2fxCCqNhqijqHKRfB8TwDutsZ8jc1Loqunkx+ZQ= =kT75 -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--