pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feed`transaction_read_only` GUC undocumented
7+ messages / 3 participants
[nested] [flat]
* `transaction_read_only` GUC undocumented
@ 2019-01-22 12:26 Pavlo Golub <pavlo.golub@cybertec.at>
0 siblings, 1 reply; 7+ messages in thread
From: Pavlo Golub @ 2019-01-22 12:26 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hello.
I found that `transaction_read_only`GUC is undocumented. The only place where it referenced is Hot Standby section (https://www.postgresql.org/docs/current/hot-standby.html)
Can we add description for this GUC, please?
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: `transaction_read_only` GUC undocumented
@ 2019-01-23 00:25 Michael Paquier <michael@paquier.xyz>
parent: Pavlo Golub <pavlo.golub@cybertec.at>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2019-01-23 00:25 UTC (permalink / raw)
To: Pavlo Golub <pavlo.golub@cybertec.at>; +Cc: pgsql-docs@lists.postgresql.org
On Tue, Jan 22, 2019 at 01:26:40PM +0100, Pavlo Golub wrote:
> I found that `transaction_read_only`GUC is undocumented. The only
> place where it referenced is Hot Standby section
> (https://www.postgresql.org/docs/current/hot-standby.html)
>
> Can we add description for this GUC, please?
That makes sense, now the documentation includes only a short of
roughly what it is here for and how hot standby uses it. Would you
like to write a patch for config.sgml?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: `transaction_read_only` GUC undocumented
@ 2019-01-23 04:18 Pavlo Golub <pavlo.golub@cybertec.at>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 7+ messages in thread
From: Pavlo Golub @ 2019-01-23 04:18 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs@lists.postgresql.org
<div dir='auto'><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Jan 23, 2019 02:25, Michael Paquier <michael@paquier.xyz> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">On Tue, Jan 22, 2019 at 01:26:40PM +0100, Pavlo Golub wrote:
<br>
> I found that `transaction_read_only`GUC is undocumented. The only
<br>
> place where it referenced is Hot Standby section
<br>
> (https://www.postgresql.org/docs/current/hot-standby.html)
<br>
>
<br>
> Can we add description for this GUC, please?
<br>
<br>
That makes sense, now the documentation includes only a short of
<br>
roughly what it is here for and how hot standby uses it. Would you
<br>
like to write a patch for config.sgml?
<br></p></blockquote></div></div></div><div dir="auto">Yeah, why not. Could you please give me a hint where can I find details about it? Sources or commits?</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">
--
<br>
Michael
<br>
</p>
</blockquote></div><br></div></div></div>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: `transaction_read_only` GUC undocumented
@ 2019-01-23 05:54 Michael Paquier <michael@paquier.xyz>
parent: Pavlo Golub <pavlo.golub@cybertec.at>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2019-01-23 05:54 UTC (permalink / raw)
To: Pavlo Golub <pavlo.golub@cybertec.at>; +Cc: pgsql-docs@lists.postgresql.org
On Wed, Jan 23, 2019 at 06:18:58AM +0200, Pavlo Golub wrote:
> Yeah, why not. Could you please give me a hint where can I find
> details about it? Sources or commits?
(You may want to avoid HTML..)
transaction_read_only is listed in src/backend/utils/misc/guc.c, so we
could put a description close to default_transaction_read_only in
config.sgml, except that transaction_read_only sets the current
transaction's read-only status.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: `transaction_read_only` GUC undocumented
@ 2019-01-23 06:07 Tom Lane <tgl@sss.pgh.pa.us>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 7+ messages in thread
From: Tom Lane @ 2019-01-23 06:07 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Pavlo Golub <pavlo.golub@cybertec.at>; pgsql-docs@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we
> could put a description close to default_transaction_read_only in
> config.sgml, except that transaction_read_only sets the current
> transaction's read-only status.
Do we really want to document that? It's not the standard-approved
way of making a transaction read-only.
regards, tom lane
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: `transaction_read_only` GUC undocumented
@ 2019-01-23 06:14 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2019-01-23 06:14 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Pavlo Golub <pavlo.golub@cybertec.at>; pgsql-docs@lists.postgresql.org
On Wed, Jan 23, 2019 at 01:07:31AM -0500, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we
>> could put a description close to default_transaction_read_only in
>> config.sgml, except that transaction_read_only sets the current
>> transaction's read-only status.
>
> Do we really want to document that? It's not the standard-approved
> way of making a transaction read-only.
i'd rather document them clearly rather than letting them around with
users guessing what they actually do (remember the recent thread about
replication parameter in connection strings). By the way, I can see
that transaction_deferrable and transaction_isolation are not around
either...
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: `transaction_read_only` GUC undocumented
@ 2019-01-23 06:56 Pavlo Golub <pavlo.golub@cybertec.at>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 7+ messages in thread
From: Pavlo Golub @ 2019-01-23 06:56 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-docs@lists.postgresql.org
Greetings, Michael.
You wrote 23.01.2019, 8:14:
> On Wed, Jan 23, 2019 at 01:07:31AM -0500, Tom Lane wrote:
>> Michael Paquier <michael@paquier.xyz> writes:
>>> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we
>>> could put a description close to default_transaction_read_only in
>>> config.sgml, except that transaction_read_only sets the current
>>> transaction's read-only status.
>>
>> Do we really want to document that? It's not the standard-approved
>> way of making a transaction read-only.
> i'd rather document them clearly rather than letting them around with
> users guessing what they actually do (remember the recent thread about
> replication parameter in connection strings).
Exactly my case. Client sent support request stating that changing
this parameter doesn't work. Of course, he was doing this outside of
transaction. And of course he doesn't find manual reference and was
guessing about it's behavior.
> By the way, I can see
> that transaction_deferrable and transaction_isolation are not around
> either...
> --
> Michael
--
Kind regards,
Pavlo mailto:pavlo.golub@cybertec.at
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2019-01-23 06:56 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 12:26 `transaction_read_only` GUC undocumented Pavlo Golub <pavlo.golub@cybertec.at>
2019-01-23 00:25 ` Michael Paquier <michael@paquier.xyz>
2019-01-23 04:18 ` Pavlo Golub <pavlo.golub@cybertec.at>
2019-01-23 05:54 ` Michael Paquier <michael@paquier.xyz>
2019-01-23 06:07 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-01-23 06:14 ` Michael Paquier <michael@paquier.xyz>
2019-01-23 06:56 ` Pavlo Golub <pavlo.golub@cybertec.at>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox