Date: Wed, 10 Jul 2019 16:13:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Amit Langote <amitlangote09@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Bruce Momjian <bruce@momjian.us>, phil.bayer@gmail.com,
	pgsql-docs@lists.postgresql.org,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Postgres 11: Table Partitioning and Primary Keys
Message-ID: <20190710071307.GB5042@paquier.xyz>
References: <20190709225333.GA18051@alvherre.pgsql>
 <1341.1562713199@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tsOsTdHNUZQcU9Ye"
Content-Disposition: inline
In-Reply-To: <1341.1562713199@sss.pgh.pa.us>
Precedence: bulk


--tsOsTdHNUZQcU9Ye
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 09, 2019 at 06:59:59PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>      <listitem>
>>       <para>
>>        Unique constraints on partitioned tables (as well as primary keys)
>>        must constrain all the partition key columns.  This limitation ex=
ists
>>        because <productname>PostgreSQL</productname> can only enforce
>>        uniqueness in each partition individually.
>>       </para>
>>      </listitem>
>=20
>> I'm not really sure about the "must constrain" verbiage.  Is that really
>> comprehensible?
>=20
> I think "must include" might be better.

+1.

>> which may not be the pinnacle of clarity, but took some time to craft
>> and I think is correct.  Also it doesn't mention primary keys
>> explicitly; maybe we should patch it by adding "(as well as a primary
>> key)" right after "a unique constraint".  Thoughts?
>=20
> I'd leave that alone.  I don't think the parenthetical comment about
> primary keys in your new text is adding much either.

Agreed with not bothering about this block and not adding the
parenthetical comment.
--
Michael

--tsOsTdHNUZQcU9Ye
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0lkAMACgkQnvQgOdby
QH371RAAnPM9l4ysNed1G3T+s2WEtkuFfeie/zzZM+HqJVIUYHO7/RFVfqVsQjrh
zrQPS+e1HlwcaZMomghAb25ytjfeA9lxFljzy6cePtmCG9U4GhTMgH37hSfURoeQ
jtFh21cWDJ4TWPiiCJU7M4cInEtTjNu2AdFMxyBtGhIfvk/h80at5jWDdZ/G7iHZ
QZpZifT4UC2OUwcbJRPVUPhJZ4HM6RlPH071t2qe1nc8LVewFOnGFhqwQwVJwVFK
mCKWy5cKwaSmEz7poAAjmrhQGfGCxQplPc48orPotfJfwVklkCTY+ws3+abwrkzW
8m1d5dDHtVEz+qcnQYg8pwRXe8VxQhnMb/OcwKoLyQ22r3ztxwIwp89mC8hrDjYl
895AREupZxXG3dmnMO9DZdPBJxYorN5k4lIWiH6xg5TixSVaIhIi4mTznXJ2Jjx5
pV21epoAO+3A7GsmjgR3uqN9EaeOkxKBRy6Tua/K3VVYvRdIBmz5TnerPaEHYHw9
8DDw8378ZxX2St5dW4ZEpCu5VRlyeXl0mAplHbNkdmUDPXF8JiRGAidGQ2cI1EKD
RKtV6w4zbRRRoo6f17lJaTGWMAX7e8cAGO4KlPExPouSmERelY9KSkPT5c2IEt7X
fRqTRZJPr1wLUL2bMJdOBkqXpw1Hszoi/VcsafweK8Ajjzj2iS8=
=tCfd
-----END PGP SIGNATURE-----

--tsOsTdHNUZQcU9Ye--