Date: Fri, 12 Jul 2019 13:44:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Liudmila Mantrova <l.mantrova@postgrespro.ru>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: misc doc fixes for REL_12_STABLE
Message-ID: <20190712044418.GG2149@paquier.xyz>
References: <a068f947-7a51-5df1-b3fd-1a131ae5c044@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oXNgvKVxGWJ0RPMJ"
Content-Disposition: inline
In-Reply-To: <a068f947-7a51-5df1-b3fd-1a131ae5c044@postgrespro.ru>
Precedence: bulk


--oXNgvKVxGWJ0RPMJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 11, 2019 at 05:49:26PM +0300, Liudmila Mantrova wrote:
> Please consider a patch that fixes some trivial issues in new doc fragments
> (a couple of typos/ambiguities and some tags that affect translation).

Thanks for the patch.  I have one comment.

> -     backups.  Moreover, because it writes a backup_label file on the
> -     master, it can cause the master to fail to restart automatically after
> -     a crash.  On the other hand, the erroneous removal of a backup_label
> -     file from a backup or standby is a common mistake which can result
> +     backups.  Moreover, because it creates a backup label file, as
> +     described below, it can block automatic restart of the master server
> +     after a crash. On the other hand, the erroneous removal of this
> +     file from a backup or standby is a common mistake, which can result
>       in serious data corruption.  If it is necessary to use this method,
>       the following steps may be used.

Okay, yes that could be a bit confusing for the reader.  Nit: I would
replace "master" with "primary" while we are in the area.  What do you
think?

But that's the only comment I have, the rest looks good!
--
Michael

--oXNgvKVxGWJ0RPMJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl0oECIACgkQnvQgOdby
QH0iDw//TTfhciFptLL/qfCJ8o0zmMLQszjGTP2Imw0Z5bzz68QlHVLPn8BMEMzw
pMl9ryAxhZdRGqo5KNBB67R+VcaYrrjbIhCprdE8EmgmWPZQAY1SAkxEqk5KPuoM
XoHuZq0Qca7KgXgdfWGCp+Kk5lXS9EQNjGyhEOKfe0h9MmCgtYmfgz3dSgto6Vx3
SdsV4nF8THb0inRXsV9x4ggqnpJonNaO0v8Vbhkyv/7ucbOPe1d9yc90bLh5wBij
LZUvjaL3Ffz3pBZWz4sihmi7XknGWhs71PLqJ22uRcTQu01LZPtW2xlDPhpNEzG9
nlPdZwE1Yj88zjoXKLgENeM5RkoN0R4ohQpMvCpP2UQI1JU0Q1Ewj6rAAU+3w3T7
mWA0bf28EeZShpMUXboe9q6p6Up5VCYoU1ai331rOI8dBZWbmLlicPrI/+m8yrxk
JLsTcxYuQ7c4CNoN1FVVnxbD9QRPmhACYgizXxUqUcVijnxMSoIk2kiBppadHCz9
Rbb9I0fhVqT6Jvb5kuJJ61JOIfJmrasCOGZHEWVYv4pmzoG6UwJf+LqosmUVD5qq
WDigD2bPB/hMqkZyhvm3zlIGEBfOS9DBDgn4Mr/6TpFX5DVMXRJh73nJ+ogn1/xV
a6RltcH1bKtV7bKsLyea0xNEtm8vaYl5kru4ewka+9ESHNyP4EI=
=USfl
-----END PGP SIGNATURE-----

--oXNgvKVxGWJ0RPMJ--