Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1i0HpG-0000R4-VY
	for pgsql-docs@arkaria.postgresql.org; Wed, 21 Aug 2019 04:02:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1i0HpF-0001Ci-CE
	for pgsql-docs@arkaria.postgresql.org; Wed, 21 Aug 2019 04:02:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <hoshiai@sraoss.co.jp>)
	id 1i0HpF-0001Ca-4q
	for pgsql-docs@lists.postgresql.org; Wed, 21 Aug 2019 04:02:21 +0000
Received: from sraihb2.sra.co.jp ([202.32.10.6])
	by magus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <hoshiai@sraoss.co.jp>)
	id 1i0Hp7-0004oB-K2
	for pgsql-docs@postgresql.org; Wed, 21 Aug 2019 04:02:20 +0000
Received: from srascf.sra.co.jp (srascf [133.137.8.80])
	by sraihb2.sra.co.jp (Postfix) with ESMTP id 8FC072A1652
	for <pgsql-docs@postgresql.org>; Wed, 21 Aug 2019 13:02:11 +0900 (JST)
Received: from srascb.sra.co.jp (unknown [133.137.8.65]) by srascf.sra.co.jp
 with smtp
	 id 3b50_02c5_fa2f3c32_f8dc_465e_863e_12cf79e634df;
	Wed, 21 Aug 2019 13:02:11 +0900
Received: from sranhm.sra.co.jp (osspc25 [133.137.174.97])
	by srascb.sra.co.jp (Postfix) with ESMTP id 656642D6943
	for <pgsql-docs@postgresql.org>; Wed, 21 Aug 2019 13:02:11 +0900 (JST)
Received: from DESKTOP-BV1V8US (dhcp-175-196.sra.co.jp [133.137.175.196])
	by sranhm.sra.co.jp (Postfix) with SMTP id 3D380A1037;
	Wed, 21 Aug 2019 13:02:11 +0900 (JST)
Date: Wed, 21 Aug 2019 13:03:01 +0900
From: Takuma Hoshiai <hoshiai@sraoss.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@postgresql.org
Subject: Re: wrong Visual Studio Edition 's name
Message-Id: <20190821130301.43bded469ed4b4fdb879ae56@sraoss.co.jp>
In-Reply-To: <20190820101901.GB1684@paquier.xyz>
References: <20190820120231.f905542e685140258ca73d82@sraoss.co.jp>
	<20190820050045.GB1841@paquier.xyz>
	<20190820142004.2a5107c7fe3773df3066ddc9@sraoss.co.jp>
	<20190820053709.GE1841@paquier.xyz>
	<20190820153828.7ed0d6f4b2df797b1eeb93a7@sraoss.co.jp>
	<20190820101901.GB1684@paquier.xyz>
X-Mailer: Sylpheed Pro 2.5.1 (GTK+ 2.24.23; i686-pc-mingw32; Pro 2.5.1)
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="Multipart=_Wed__21_Aug_2019_13_03_01_+0900_oLFJ9Jk=XkLR6Sj_"
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

This is a multi-part message in MIME format.

--Multipart=_Wed__21_Aug_2019_13_03_01_+0900_oLFJ9Jk=XkLR6Sj_
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 20 Aug 2019 19:19:01 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote:
> > I have attached a patch. The word of "Express" existed in four
> > places, they will are fixed by this patch. 
> 
> -  These compilers can be either from <productname>Visual Studio</productname>,
> -  <productname>Visual Studio Express</productname> or some versions of the
> -  <productname>Microsoft Windows SDK</productname>. If you do not already have a
> -  <productname>Visual Studio</productname> environment set up, the easiest
> -  ways are to use the compilers from <productname>Visual Studio Express 2019
> -  for Windows Desktop</productname> or those in the <productname>Windows SDK
> +  These compilers can be either from <productname>Visual Studio</productname>
> +  or some versions of the <productname>Microsoft Windows SDK</productname>.
> +  If you do not already have a <productname>Visual Studio</productname> 
> +  environment set up, the easiest ways are to use the compilers
> +  from <productname>Visual Studio 2019</productname>
> +  or those in the <productname>Windows SDK
>    10</productname>, which are both free downloads from Microsoft.
> 
> I may be missing something, but this refers to all the possible
> flavors of VS where compilers are available, hence mentioning Visual
> Studio Express is still correct when going through our full supported
> range from VS 2013 to VS 2019, no?  That's why I said only two places
> need to be fixed, as this area is fine.

Yes, Express edition is contained by supported range. But my understanding
is that other Edition are also same. The reason for changing above sentence,
was that I thought that we don't need to specify Express edition only.

The above original sentence is no problem too, so I have reattached a patch,
which is fixed "Express 2019" only.

> --
> Michael


-- 
Takuma Hoshiai <hoshiai@sraoss.co.jp>

--Multipart=_Wed__21_Aug_2019_13_03_01_+0900_oLFJ9Jk=XkLR6Sj_
Content-Type: application/octet-stream;
 name="vs_edition_fix_v2.patch"
Content-Disposition: attachment;
 filename="vs_edition_fix_v2.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9pbnN0YWxsLXdpbmRvd3Muc2dtbCBiL2RvYy9zcmMv
c2dtbC9pbnN0YWxsLXdpbmRvd3Muc2dtbAppbmRleCAwYmJiMzE0Li5jNmU0YWZlIDEwMDY0NAot
LS0gYS9kb2Mvc3JjL3NnbWwvaW5zdGFsbC13aW5kb3dzLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21s
L2luc3RhbGwtd2luZG93cy5zZ21sCkBAIC0xOSw5ICsxOSw4IEBACiAgPHBhcmE+CiAgIFRoZXJl
IGFyZSBzZXZlcmFsIGRpZmZlcmVudCB3YXlzIG9mIGJ1aWxkaW5nIFBvc3RncmVTUUwgb24KICAg
PHByb2R1Y3RuYW1lPldpbmRvd3M8L3Byb2R1Y3RuYW1lPi4gVGhlIHNpbXBsZXN0IHdheSB0byBi
dWlsZCB3aXRoCi0gIE1pY3Jvc29mdCB0b29scyBpcyB0byBpbnN0YWxsIDxwcm9kdWN0bmFtZT5W
aXN1YWwgU3R1ZGlvIEV4cHJlc3MgMjAxOQotICBmb3IgV2luZG93cyBEZXNrdG9wPC9wcm9kdWN0
bmFtZT4gYW5kIHVzZSB0aGUgaW5jbHVkZWQKLSAgY29tcGlsZXIuIEl0IGlzIGFsc28gcG9zc2li
bGUgdG8gYnVpbGQgd2l0aCB0aGUgZnVsbAorICBNaWNyb3NvZnQgdG9vbHMgaXMgdG8gaW5zdGFs
bCA8cHJvZHVjdG5hbWU+VmlzdWFsIFN0dWRpbyAyMDE5PC9wcm9kdWN0bmFtZT4KKyAgYW5kIHVz
ZSB0aGUgaW5jbHVkZWQgY29tcGlsZXIuIEl0IGlzIGFsc28gcG9zc2libGUgdG8gYnVpbGQgd2l0
aCB0aGUgZnVsbAogICA8cHJvZHVjdG5hbWU+TWljcm9zb2Z0IFZpc3VhbCBDKysgMjAxMyB0byAy
MDE5PC9wcm9kdWN0bmFtZT4uCiAgIEluIHNvbWUgY2FzZXMgdGhhdCByZXF1aXJlcyB0aGUgaW5z
dGFsbGF0aW9uIG9mIHRoZQogICA8cHJvZHVjdG5hbWU+V2luZG93cyBTREs8L3Byb2R1Y3RuYW1l
PiBpbiBhZGRpdGlvbiB0byB0aGUgY29tcGlsZXIuCkBAIC02OSw4ICs2OCw4IEBACiAgIDxwcm9k
dWN0bmFtZT5WaXN1YWwgU3R1ZGlvIEV4cHJlc3M8L3Byb2R1Y3RuYW1lPiBvciBzb21lIHZlcnNp
b25zIG9mIHRoZQogICA8cHJvZHVjdG5hbWU+TWljcm9zb2Z0IFdpbmRvd3MgU0RLPC9wcm9kdWN0
bmFtZT4uIElmIHlvdSBkbyBub3QgYWxyZWFkeSBoYXZlIGEKICAgPHByb2R1Y3RuYW1lPlZpc3Vh
bCBTdHVkaW88L3Byb2R1Y3RuYW1lPiBlbnZpcm9ubWVudCBzZXQgdXAsIHRoZSBlYXNpZXN0Ci0g
IHdheXMgYXJlIHRvIHVzZSB0aGUgY29tcGlsZXJzIGZyb20gPHByb2R1Y3RuYW1lPlZpc3VhbCBT
dHVkaW8gRXhwcmVzcyAyMDE5Ci0gIGZvciBXaW5kb3dzIERlc2t0b3A8L3Byb2R1Y3RuYW1lPiBv
ciB0aG9zZSBpbiB0aGUgPHByb2R1Y3RuYW1lPldpbmRvd3MgU0RLCisgIHdheXMgYXJlIHRvIHVz
ZSB0aGUgY29tcGlsZXJzIGZyb20gPHByb2R1Y3RuYW1lPlZpc3VhbCBTdHVkaW8gMjAxOTwvcHJv
ZHVjdG5hbWU+CisgIG9yIHRob3NlIGluIHRoZSA8cHJvZHVjdG5hbWU+V2luZG93cyBTREsKICAg
MTA8L3Byb2R1Y3RuYW1lPiwgd2hpY2ggYXJlIGJvdGggZnJlZSBkb3dubG9hZHMgZnJvbSBNaWNy
b3NvZnQuCiAgPC9wYXJhPgogCg==

--Multipart=_Wed__21_Aug_2019_13_03_01_+0900_oLFJ9Jk=XkLR6Sj_--