Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iDa12-00005m-5d for pgsql-docs@arkaria.postgresql.org; Thu, 26 Sep 2019 20:05:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iDa11-0002p8-0v for pgsql-docs@arkaria.postgresql.org; Thu, 26 Sep 2019 20:05:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iDa10-0002p1-QY for pgsql-docs@lists.postgresql.org; Thu, 26 Sep 2019 20:05:26 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iDa0y-0001za-64 for pgsql-docs@postgresql.org; Thu, 26 Sep 2019 20:05:26 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1iDa0w-0000ju-Jg; Thu, 26 Sep 2019 16:05:22 -0400 Date: Thu, 26 Sep 2019 16:05:22 -0400 From: Bruce Momjian To: Alvaro Herrera Cc: Tomas Vondra , PostgreSQL-documentation Subject: Re: Most-common value docs in PG 12 Message-ID: <20190926200522.GB16366@momjian.us> References: <20190830232804.GA10645@momjian.us> <20190911211522.GA7762@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190911211522.GA7762@alvherre.pgsql> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > On 2019-Aug-30, Bruce Momjian wrote: > > > OK, how is this patch? I didn't mention psql since I think everyone > > expects psql to show all information about tables and indexes. > > Why would you change perform.sgml? It seems unnecessary; the commands > shown work fine. I realize they work fine, but the ordering in the examples not matching the defined order suggests that ordering matters, but it does not. --------------------------------------------------------------------------- > > This part seems okay: > > > diff --git a/doc/src/sgml/ref/create_statistics.sgml b/doc/src/sgml/ref/create_statistics.sgml > > index ec23a154d6..5b583aacb4 100644 > > --- a/doc/src/sgml/ref/create_statistics.sgml > > +++ b/doc/src/sgml/ref/create_statistics.sgml > > @@ -98,7 +98,8 @@ CREATE STATISTICS [ IF NOT EXISTS ] statistics_na > > > > > > The name of a table column to be covered by the computed statistics. > > - At least two column names must be given. > > + At least two column names must be given; the order of the column names > > + is insignificant. > > > > > > > > -- > Álvaro Herrera https://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +