Date: Mon, 30 Sep 2019 10:24:27 -0400
From: Bruce Momjian <bruce@momjian.us>
To: bryn@yugabyte.com, pgsql-docs@lists.postgresql.org
Subject: Re: Chapter 43.8. "Transaction Management" fails to state two
 critical restrictions
Message-ID: <20190930142427.GA8385@momjian.us>
References: <156981670710.26184.2375673917366850651@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <156981670710.26184.2375673917366850651@wrigleys.postgresql.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Sep 30, 2019 at 04:11:47AM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/11/plpgsql-transactions.html
> Description:
> 
> This chapter fails to state:
> 
> (1) If a PL/pgSQL procedure issues "commit" then it must be called with
> AUTOCOMMIT set to On. This is counter-intuitive. You'd expect the
> opposite.

You mean psql autocommit mode?

> (2) If a PL/pgSQL procedure has a block statement with an exception section
> (this might be the procedure's defining block, or an inner block) then that
> block's executabe section must not issue "commit". Doing so causes a
> run-time error.

Uh, that's a good point since you are in a subtransaction at that point.
What error do you get?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +