Date: Tue, 8 Oct 2019 21:49:55 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, basil.bourque@gmail.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15912: The units of `autovacuum_vacuum_cost_delay` setting
 should be documented
Message-ID: <20191009014955.GA3191@momjian.us>
References: <C6E10B26-97E0-4B4D-9AEE-E26A7E2263F9@yesql.se>
 <20190726220242.GA16906@alvherre.pgsql>
 <20190727214130.bjgyv2holjng3oeb@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190727214130.bjgyv2holjng3oeb@momjian.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sat, Jul 27, 2019 at 05:41:30PM -0400, Bruce Momjian wrote:
> On Fri, Jul 26, 2019 at 06:02:42PM -0400, Alvaro Herrera wrote:
> > Now you could complain that this is inconsistent with other
> > descriptions; for example, log_autovacuum_min_duration talks about
> > milliseconds, which sounds a bit archaic to me:
> > 
> >    Causes each action executed by autovacuum to be logged if it ran for
> >    at least the specified number of milliseconds. Setting this to zero
> >    logs all autovacuum actions. -1 (the default) disables logging
> >    autovacuum actions. For example, if you set this to 250ms then all
> >    automatic vacuums and analyzes that run 250ms or longer will be
> >    logged. In addition, when this parameter is set to any value other
> >    than -1, a message will be logged if an autovacuum action is skipped
> >    due to a conflicting lock or a concurrently dropped relation.
> >    Enabling this parameter can be helpful in tracking autovacuum
> >    activity. This parameter can only be set in the postgresql.conf file
> >    or on the server command line; but the setting can be overridden for
> >    individual tables by changing table storage parameters.
> > 
> > 
> > I'm not really sure what's a good way to attack this problem, but I
> > doubt that focusing on just one description is a sufficient solution.
> 
> Yes, I looked at this earlier in the week and had the same conclusion. 
> I went over config.sgml and saw many inconsistencies of the same type
> being complained about here.
> 
> I went through the file and found a number of cases using milliseconds
> and kilobytes that were unclear, and adjusted them.  I dealt only with
> the cases where the base unit (seconds/bytes) was not the default unit. 
> Patch attached.

I applied a modified version of this patch.  I didn't backpatch it past
PG 12 because earlier releases were just too different.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +