Date: Thu, 17 Oct 2019 10:33:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: emorley@heroku.com, pgsql-docs@lists.postgresql.org
Cc: Bruce Momjian <bruce@momjian.us>
Subject: Re: PostgreSQL 12 release notes missing breaking change in libpq
Message-ID: <20191017013310.GC5605@paquier.xyz>
References: <157123155668.25311.9369950798665566339@wrigleys.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C"
Content-Disposition: inline
In-Reply-To: <157123155668.25311.9369950798665566339@wrigleys.postgresql.org>
Precedence: bulk


--NU0Ex4SbNnrxsi6C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 16, 2019 at 01:12:36PM +0000, PG Doc comments form wrote:
> In PostgreSQL 12, libpq's parsing of connection string integer parameters
> was made more strict, such that invalid values now result in an error rat=
her
> than being silently ignored:
> https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e4=
5716cfcbefb
>=20
> This change resulted in runtime errors/crashes for some of our customers
> after we upgraded the Heroku stack images to use v12 of the PostgreSQL
> client libs.
>=20
> We had checked the release notes, but it's not currently mentioned:
> https://www.postgresql.org/docs/12/release-12.html
>=20
> Please could it be added?

I think it makes sense to mention that.  Bruce, why not adding an item
about that in the "Migration to Version 12" section?  Was that
intentionally left out?
--
Michael

--NU0Ex4SbNnrxsi6C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2nxNYACgkQnvQgOdby
QH0n0Q/8D0Tliz+Lrx1q7s1uxvcCbBekVT9SODy7Dgp356ma+fh7u7evBgdri+Qz
y/hQp0cd6KON+zgJ6WPSNUwXhyyAdh6kSITP8+qGieK0QRFaGFu6w9r7S9IAGeVq
zZUGGVv+Co8Kh7xGeB5s11uWKujgnt5ji2JeEmEqFDIhWXdIcziyzY9SvpsoXAHq
Y4W+tQJaGYL6ZF7JmVAZx3dhJ1WEV/xFFFBCpLcDlL2vAXNHQqb8Xwti6E186fiY
yN1w5nCV/25Ld9VtN+YeutTw0Xuspqs3C8gqcw0Trh8e6YGCLxt4drQjTrz/7LFi
VzJc58J5Vk4tNxKmDQHu87193fKB98Q1Z0sgBlZLuVyYPDtPlQYe2PbFNn8CHKuV
al1wn0LUwQRXok9MCY+E7+YAbHQ9YoMOEzGVK4nM8GMSp34XyaqS1RQPGGN66K0B
VYWYTJ1EqibQfZgZKv1HelklFQVdOpLmHMn+ZtUe9xVSPMEMBJW6768MFb8MaVeV
S9kytpFhPqddukMQpFKLiHybHoAawnyMiIWGVMfSNoHM6+FoIIkCj3X/O+oJ83eO
1qCBNRztwjyxQDqeFT8D7H0aZf7v/iO45mppNUQR0jCPdS0wmcOnvQ9YCqLStmh7
FAs8gU8mw3ST6qRHM6KvC6HhOLUjBCzD3ypLhaJ50xOmVn3x4w0=
=hk6M
-----END PGP SIGNATURE-----

--NU0Ex4SbNnrxsi6C--