Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1iPs0n-0002DQ-VC
	for pgsql-docs@arkaria.postgresql.org; Wed, 30 Oct 2019 17:44:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1iPs0m-0005iC-NW
	for pgsql-docs@arkaria.postgresql.org; Wed, 30 Oct 2019 17:44:00 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <bruce@momjian.us>)
	id 1iPs0m-0005i5-Cz
	for pgsql-docs@lists.postgresql.org; Wed, 30 Oct 2019 17:44:00 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1iPs0j-0002kt-TD
	for pgsql-docs@lists.postgresql.org; Wed, 30 Oct 2019 17:43:59 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1iPs0h-0006iL-4y; Wed, 30 Oct 2019 13:43:55 -0400
Date: Wed, 30 Oct 2019 13:43:55 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: emorley@heroku.com, pgsql-docs@lists.postgresql.org
Subject: Re: PostgreSQL 12 release notes missing breaking change in libpq
Message-ID: <20191030174355.GA23041@momjian.us>
References: <157123155668.25311.9369950798665566339@wrigleys.postgresql.org>
 <20191017013310.GC5605@paquier.xyz>
 <20191024020544.GD8650@momjian.us>
 <20191030042948.GB20808@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="sdtB3X0nJg68CQEu"
Content-Disposition: inline
In-Reply-To: <20191030042948.GB20808@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk


--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 30, 2019 at 01:29:48PM +0900, Michael Paquier wrote:
> On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> > My reading of the commit message is that the error messages will just be
> > more helpful now, not that some things would now error that use to be
> > ignored.  I am still unclear exactly what the release notes should say.
> 
> Nay.  It could be worse as in some cases like for the keepalive
> parameters, the values would be just silently ignored.  Please let me
> suggest the attached for the release notes of REL_12_STABLE.

Thanks for the patch.  I slightly modified the wording and applied the
attached patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff

diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
new file mode 100644
index 126d614..337a7a2
*** a/doc/src/sgml/release-12.sgml
--- b/doc/src/sgml/release-12.sgml
*************** Author: Peter Eisentraut <peter_e@gmx.ne
*** 654,659 ****
--- 654,681 ----
       </para>
      </listitem>
  
+     <listitem>
+ <!--
+ Author: Michael Paquier <michael@paquier.xyz>
+ 2018-09-12 [e7a221797] Parse more strictly integer parameters from connection s
+ -->
+ 
+      <para>
+       Parse libpq integer connection parameters more strictly (Fabien
+       Coelho)
+      </para> 
+ 
+      <para>
+       In previous releases, using an incorrect integer value for
+       connection parameters <literal>connect_timeout</literal>,
+       <literal>keepalives</literal>, <literal>keepalives_count</literal>,
+       <literal>keepalives_idle</literal>,
+       <literal>keepalives_interval</literal> and <literal>port</literal>
+       resulted in libpq either ignoring those values or failing with
+       incorrect error messages.
+      </para> 
+     </listitem>
+     
     </itemizedlist>
  
    </sect2>

--sdtB3X0nJg68CQEu--