Date: Tue, 5 Nov 2019 13:27:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bruce Momjian <bruce@momjian.us>
Cc: d.aumueller@proventa.de, pgsql-docs@lists.postgresql.org
Subject: Re: wal_sender_timeout / wal_receiver_timeout - seconds or
 milliseconds?
Message-ID: <20191105042716.GH16867@paquier.xyz>
References: <157192240500.1043.7917781375772404449@wrigleys.postgresql.org>
 <20191105025234.GC12780@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="sl5MdczEF/OU2Miu"
Content-Disposition: inline
In-Reply-To: <20191105025234.GC12780@momjian.us>
Precedence: bulk


--sl5MdczEF/OU2Miu
Content-Type: multipart/mixed; boundary="it/zdz3K1bH9Y8/E"
Content-Disposition: inline


--it/zdz3K1bH9Y8/E
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 04, 2019 at 09:52:34PM -0500, Bruce Momjian wrote:
> The default _value_ is 60 seconds, and we use the 's' to specify
> seconds.  What the comment is saying is that if you _don't_ specify any
> units, the integer is in milliseconds.  I am not sure how to improve
> that.

I do have a suggestion as per the attached, say:
+#wal_sender_timeout = 60s      # in milliseconds if no unit specified;
+                               # 0 disables
--
Michael

--it/zdz3K1bH9Y8/E
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pgconf-units.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/ut=
ils/misc/postgresql.conf.sample
index 0fc23e3a61..eea017e840 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -286,7 +286,8 @@
 #max_wal_senders =3D 10		# max number of walsender processes
 				# (change requires restart)
 #wal_keep_segments =3D 0		# in logfile segments; 0 disables
-#wal_sender_timeout =3D 60s	# in milliseconds; 0 disables
+#wal_sender_timeout =3D 60s	# in milliseconds if no unit specified;
+				# 0 disables
=20
 #max_replication_slots =3D 10	# max number of replication slots
 				# (change requires restart)
@@ -326,7 +327,8 @@
 					# query conflicts
 #wal_receiver_timeout =3D 60s		# time that receiver waits for
 					# communication from master
-					# in milliseconds; 0 disables
+					# in milliseconds if no unit specified;
+					# 0 disables
 #wal_retrieve_retry_interval =3D 5s	# time to wait before retrying to
 					# retrieve WAL after a failed attempt
 #recovery_min_apply_delay =3D 0		# minimum delay for applying changes duri=
ng recovery

--it/zdz3K1bH9Y8/E--

--sl5MdczEF/OU2Miu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3A+iQACgkQnvQgOdby
QH3dOA/9GOz2yMmlZgaix15vRmL1bMuQcSwRJYeTdAiC+XY749mCn93OUHjcijlC
1bTh4aTlI/19V476ocI+LB/wUsNP1wuekWj9exQcOpXOsSsMPBEV1AKhOTKAMcbW
gCYp5o5U4o9i2pWlFDIHzTuvV2DBSxCsV5ejMR3DvnpWk6yRXs7CczBkBvkhSeNe
NV1kj8zVUFJfXhaCx16INl4/+LW51Flv8w8ytWn0W6lQMzHMADlRcSEPZQvjV5x1
Eu1FH9XcTdJ+vJpyP9NMuT05dcvsn13NWDlJW9XR6TyCjvWwW7CW/UDDEZxVf6nw
L4iuQWxBYEMUtx5ApFtRUw537FfxMWVhVRyt3G8wTAgHEa51MNi539Y3UuzVDT/H
nzJcdU52YtonkgGSJiTetNsZhcqXfFsg6v2i/vMAwJCd/UAnI2m61ieNm7wr2/dl
TibZB3QKFyvGYndRmIbZkBw8YZ5sZgJGJnI8DSZplsxBpsW4Is/dBf5bEmAKqjHj
PHKlKvznqzYSEL0psXVFNYm992fxnQQp40UAdJDfdq3Hnae3eTmDQsU//eKG71V4
NP1jWBcor2xInRuCruK8CMavuGCHTtc0ZXAHFtUSNeL2a782OhW9pwpREbgONuFp
ks3t4K/LqRk4yhmx9mStEgklz+cgXMWiBtnV76QsEwALPiQtQL8=
=F7ye
-----END PGP SIGNATURE-----

--sl5MdczEF/OU2Miu--