Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSFwO-00044F-0K for pgsql-docs@arkaria.postgresql.org; Wed, 06 Nov 2019 07:41:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iSFwM-0002a8-Hj for pgsql-docs@arkaria.postgresql.org; Wed, 06 Nov 2019 07:41:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSFwM-0002a1-AL for pgsql-docs@lists.postgresql.org; Wed, 06 Nov 2019 07:41:18 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSFwL-0001h9-0e for pgsql-docs@lists.postgresql.org; Wed, 06 Nov 2019 07:41:17 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5C8B121C29; Wed, 6 Nov 2019 02:41:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Nov 2019 02:41:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+a1LcdNRlM9IfqlQlLoCmMC97HS dM7NcqJDBT4toSTg=; b=QZxLYSfcrPlpecN8th3JVZq957AFxB5iP98+uwbnbjv X5BmlH2HyalGSccmcVssNg6NWx9VwSnlUcwjFsDGGh4LDbS5s+stsLEPvKzAY/x/ lJN6Gi6fZDsjdMdMq+yvA+xkoWo5ks6cosC4N5b5o+DKtq3dmBLiDP8K5yJxqxUF kqgGyc3yrAV9qXGn1RFDfghjYrKPneI/791YYNvOLGTUdMjjFKKt78pba5Vv/Dj/ m4DrOm6SiWe/vUfLXenVno36c1c/eGnqYnNogvpUE18k8ofRh0Shy38yuiOu6Qs7 Ta1t505O6251Nrk9q/QMJD++XfJwIrZM7NGGTzHrwTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+a1Lcd NRlM9IfqlQlLoCmMC97HSdM7NcqJDBT4toSTg=; b=DDWYUaR4HELatb+s4ro9Jb Mr/hzZ4cdJrS/ecmzQSjRMBGuITnB88y52f20lHF7WPGcqnF7eb4rayweUW8PcCG jEQmINdrBwIm12uNuUOpAO0jkGjQo6r6neZ+g2TJgXvzQhgyJt8kIz9xwcsIvX7K 0ofT2qtjG1Rro2fPfKY3eKof/a+GlOD+clrlTZzprsO4QCBjQeMoV9MudYkzTyh2 pNLNHLsByRUkIDkf5fDxSsacrvnOnrpuFHQnujWlilX7Z+2lik2xJmE54dTrbL50 0gfn59VXb1zu7DgBOy/QSHBUi4WUG0eVOfIfaGU7YaIUsHD4cmAbSHAE3zgXgTcA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduiedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgr rhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id C37B980065; Wed, 6 Nov 2019 02:41:13 -0500 (EST) Date: Wed, 6 Nov 2019 16:41:10 +0900 From: Michael Paquier To: Bruce Momjian Cc: d.aumueller@proventa.de, pgsql-docs@lists.postgresql.org Subject: Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds? Message-ID: <20191106074110.GJ1604@paquier.xyz> References: <157192240500.1043.7917781375772404449@wrigleys.postgresql.org> <20191105025234.GC12780@momjian.us> <20191105042716.GH16867@paquier.xyz> <20191105152138.GD12780@momjian.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZG+WKzXzVby2T9Ro" Content-Disposition: inline In-Reply-To: <20191105152138.GD12780@momjian.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ZG+WKzXzVby2T9Ro Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 05, 2019 at 10:21:38AM -0500, Bruce Momjian wrote: > Ugh, the "if no unit specified" is true of all the settings. Should we > make that clearer in a more central location. Hmm. Are you thinking about a new single location in the docs? I would be afraid to have something like that rot easily as users would most likely only read the description of each individual parameter rather than travel across multiple sections. Also, if you look at guc.c the default units of each parameter are a case-by-case. log_rotation_age uses minutes for example, autovacuum_naptime seconds, etc. -- Michael --ZG+WKzXzVby2T9Ro Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3CeRYACgkQnvQgOdby QH13zA//ZPf3Th7/njv1HMpi+iCCz46oRyoq4PguYLPLP9C0s0BMnqQGD6upsCRL Ub3TMELy94QDs5sdAKsxBOLXUVzs+iVQUgdTIpc6LJ8v3zCuKps/Tz0UUHgTOAnU PmGRWItATskVwBlRGz7f33UFXt795giVe2OLVe6qWhPOTuG7ulEX169bm75kDFft meWdjEzLBBIE2lVLvsgQVHPNRwKxhEyHqEmpt5/3s2jA9EJiLVkVrIwPfS5PQO9+ WqhhQGHIMZamo6EIsWmKWVzoG/eSQ71RP8OBIrySNdZknzYeP9yTWJFkUGcSuW47 2F2Rj2/LZYHjF5StmGngx9J5O+xPvYMY3qXNfm4WIhtw6Fs22Z5+zJrWbu8cDJBM 5Z3POTulrb2X9K3Rg81u8An6galbk8PItOvmawCBpe/rvzNnJ5OHxhuNzBVVPCp2 N1QId9qOQmMxe35a7241mNP4EgaI2ps++4RQliOLWvLdU48lGW23Zb2dpYzbSA3H eMYux861aCY2pF+E0oQTTkN+CsEsOX0MK0CS0QcIXoAEkMSGw/ZeajSMY8eh7krB lhSGQ8D+YUIzLnFhrk47UUzi2dwZS0+jF2vmCiqe5H9qlWvcZ9VyirOmx1U3nBMI XLYFRCkfApS3xkDT3cq+EfLLrTqB3aBBkBiPPUuVO/vm+Dyas/Q= =uVb6 -----END PGP SIGNATURE----- --ZG+WKzXzVby2T9Ro--