public inbox for [email protected]
help / color / mirror / Atom feedSmall typo in func.sgml
6+ messages / 4 participants
[nested] [flat]
* Small typo in func.sgml
@ 2019-11-06 23:16 Tatsuo Ishii <[email protected]>
2019-11-07 02:15 ` Re: Small typo in func.sgml Michael Paquier <[email protected]>
2019-11-07 16:56 ` Re: Small typo in func.sgml Tom Lane <[email protected]>
0 siblings, 2 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2019-11-06 23:16 UTC (permalink / raw)
To: [email protected]
I thinkk a new line is needed after <para>.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
Attachments:
[text/x-patch] func.diff (539B, 2-func.diff)
download | inline diff:
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 28eb322f3f..6d82c9f0bd 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -12879,7 +12879,8 @@ table2-mapping
<xref linkend="datatype-jsonpath"/>.
</para>
- <para>JSON query functions and operators
+ <para>
+ JSON query functions and operators
pass the provided path expression to the <firstterm>path engine</firstterm>
for evaluation. If the expression matches the queried JSON data,
the corresponding SQL/JSON item is returned.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Small typo in func.sgml
2019-11-06 23:16 Small typo in func.sgml Tatsuo Ishii <[email protected]>
@ 2019-11-07 02:15 ` Michael Paquier <[email protected]>
1 sibling, 0 replies; 6+ messages in thread
From: Michael Paquier @ 2019-11-07 02:15 UTC (permalink / raw)
To: Tatsuo Ishii <[email protected]>; +Cc: [email protected]
On Thu, Nov 07, 2019 at 08:16:15AM +0900, Tatsuo Ishii wrote:
> I think a new line is needed after <para>.
True that it is the usual pattern.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Small typo in func.sgml
2019-11-06 23:16 Small typo in func.sgml Tatsuo Ishii <[email protected]>
@ 2019-11-07 16:56 ` Tom Lane <[email protected]>
1 sibling, 0 replies; 6+ messages in thread
From: Tom Lane @ 2019-11-07 16:56 UTC (permalink / raw)
To: Tatsuo Ishii <[email protected]>; +Cc: [email protected]
Tatsuo Ishii <[email protected]> writes:
> I thinkk a new line is needed after <para>.
> - <para>JSON query functions and operators
> + <para>
> + JSON query functions and operators
It doesn't really make any difference, I believe. I agree it's
neater with the newline, but I wouldn't bother changing it unless
you're making some other nearby change.
(There are actually instances of this in quite a few places in
our docs, if memory serves. I think somebody uses, or used,
an editor that tended to remove newlines in that context.)
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Small typo in func.sgml
@ 2019-11-19 13:20 Tatsuo Ishii <[email protected]>
2019-11-19 13:35 ` Re: Small typo in func.sgml Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuo Ishii @ 2019-11-19 13:20 UTC (permalink / raw)
To: [email protected]
There's a very small typo in func.sgml. Patch attached.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
Attachments:
[text/x-patch] func.diff (831B, 2-func.diff)
download | inline diff:
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 28eb322f3f..e8082c05c9 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -20927,7 +20927,7 @@ postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
(<parameter>slot_name</parameter> <type>name</type>, <parameter>lsn</parameter> <type>pg_lsn</type>)
</entry>
<entry>
- Copies an existing logical replication slot name <parameter>src_slot_name</parameter>
+ Copies an existing logical replication slot named <parameter>src_slot_name</parameter>
to a logical replication slot named <parameter>dst_slot_name</parameter>
while changing the output plugin and persistence. The copied logical slot starts
from the same <acronym>LSN</acronym> as the source logical slot. Both
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Small typo in func.sgml
2019-11-19 13:20 Small typo in func.sgml Tatsuo Ishii <[email protected]>
@ 2019-11-19 13:35 ` Daniel Gustafsson <[email protected]>
2019-11-20 00:19 ` Re: Small typo in func.sgml Tatsuo Ishii <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Gustafsson @ 2019-11-19 13:35 UTC (permalink / raw)
To: Tatsuo Ishii <[email protected]>; +Cc: [email protected]
> On 19 Nov 2019, at 14:20, Tatsuo Ishii <[email protected]> wrote:
> <entry>
> - Copies an existing logical replication slot name <parameter>src_slot_name</parameter>
> + Copies an existing logical replication slot named <parameter>src_slot_name</parameter>
+1
cheers ./daniel
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Small typo in func.sgml
2019-11-19 13:20 Small typo in func.sgml Tatsuo Ishii <[email protected]>
2019-11-19 13:35 ` Re: Small typo in func.sgml Daniel Gustafsson <[email protected]>
@ 2019-11-20 00:19 ` Tatsuo Ishii <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Tatsuo Ishii @ 2019-11-20 00:19 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
>> On 19 Nov 2019, at 14:20, Tatsuo Ishii <[email protected]> wrote:
>
>> <entry>
>> - Copies an existing logical replication slot name <parameter>src_slot_name</parameter>
>> + Copies an existing logical replication slot named <parameter>src_slot_name</parameter>
>
> +1
Fix committed/pushed to master and REL_12_STABLE branches.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2019-11-20 00:19 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 23:16 Small typo in func.sgml Tatsuo Ishii <[email protected]>
2019-11-07 02:15 ` Michael Paquier <[email protected]>
2019-11-07 16:56 ` Tom Lane <[email protected]>
2019-11-19 13:20 Small typo in func.sgml Tatsuo Ishii <[email protected]>
2019-11-19 13:35 ` Daniel Gustafsson <[email protected]>
2019-11-20 00:19 ` Tatsuo Ishii <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox