Date: Thu, 7 Nov 2019 17:36:17 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: d.aumueller@proventa.de, pgsql-docs@lists.postgresql.org
Subject: Re: wal_sender_timeout / wal_receiver_timeout - seconds or
 milliseconds?
Message-ID: <20191107223617.GC487@momjian.us>
References: <157192240500.1043.7917781375772404449@wrigleys.postgresql.org>
 <20191105025234.GC12780@momjian.us>
 <20191105042716.GH16867@paquier.xyz>
 <20191105152138.GD12780@momjian.us>
 <20191106074110.GJ1604@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191106074110.GJ1604@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Nov  6, 2019 at 04:41:10PM +0900, Michael Paquier wrote:
> On Tue, Nov 05, 2019 at 10:21:38AM -0500, Bruce Momjian wrote:
> > Ugh, the "if no unit specified" is true of all the settings.  Should we
> > make that clearer in a more central location.
> 
> Hmm.  Are you thinking about a new single location in the docs?  I
> would be afraid to have something like that rot easily as users would
> most likely only read the description of each individual parameter
> rather than travel across multiple sections.  Also, if you look at
> guc.c the default units of each parameter are a case-by-case.
> log_rotation_age uses minutes for example, autovacuum_naptime seconds,
> etc.

Right.  I am just asking if we need to do this for _every_ case where
the default value doesn't match the default _units_, or if we need to
have some kind of central notification.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +