Date: Tue, 26 Nov 2019 15:28:18 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: miodrag.milic@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Example not producing shown output
Message-ID: <20191126182818.GC4161@alvherre.pgsql>
References: <157468351705.7229.6629196528495737297@wrigleys.postgresql.org>
 <21BF1412-3E64-4F10-8F8E-74AD0EC3AAC3@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <21BF1412-3E64-4F10-8F8E-74AD0EC3AAC3@yesql.se>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Nov-25, Daniel Gustafsson wrote:

> > On 25 Nov 2019, at 13:05, PG Doc comments form <noreply@postgresql.org> wrote:

> > Examples should have specified 'english'.
> > 
> > Instead:
> >   to_tsvector('fat cats ate rats') @@ to_tsquery('cat & rat')
> > 
> > which returns fale on my own blank installation of Postgre (Serbian locale
> > Windows OS) instead of true:
> >   to_tsvector('english', 'fat cats ate rats') @@ to_tsquery('cat & rat')
> 
> I agree with this complaint, mainly since other examples on the page do specify
> english where required AFAICT, this makes it consistent.

Hmm.  I'm not sure that it's an improvement to make all the examples
alike; that means we would not provide examples of the simpler syntax.
And because other examples already show that it's possible to indicate
the language, I'm not sure it's strictly necessary to do so here.

Maybe this complaint could be addressed by indicating in a note that
some examples might not work identically if run under a different
locale.  Or perhaps we can add a second line in the example cell for the
@@ operator, to make it clear that both forms can be used.  Users can be
expected to apply some intuition from that point onwards.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services